mirror of
https://github.com/elisiariocouto/leggen.git
synced 2025-12-14 10:52:18 +00:00
fix: correct composite key migration check
- Fix _check_composite_key_migration_needed to properly check if internalTransactionId is the primary key - Use PRAGMA table_info pk flag instead of just checking column existence - This ensures migration only runs when internalTransactionId is actually the primary key
This commit is contained in:
@@ -551,10 +551,15 @@ class DatabaseService:
|
|||||||
# Check if transactions table has the old primary key structure
|
# Check if transactions table has the old primary key structure
|
||||||
cursor.execute("PRAGMA table_info(transactions)")
|
cursor.execute("PRAGMA table_info(transactions)")
|
||||||
columns = cursor.fetchall()
|
columns = cursor.fetchall()
|
||||||
column_names = [col[1] for col in columns]
|
|
||||||
|
|
||||||
# If we have internalTransactionId as primary key, migration is needed
|
# Check if internalTransactionId is the primary key (old structure)
|
||||||
if "internalTransactionId" in column_names:
|
internal_transaction_id_is_pk = any(
|
||||||
|
col[1] == "internalTransactionId" and col[5] == 1 # col[5] is pk flag
|
||||||
|
for col in columns
|
||||||
|
)
|
||||||
|
|
||||||
|
# If internalTransactionId is still the primary key, migration is needed
|
||||||
|
if internal_transaction_id_is_pk:
|
||||||
# Check if there are duplicate (accountId, transactionId) pairs
|
# Check if there are duplicate (accountId, transactionId) pairs
|
||||||
cursor.execute("""
|
cursor.execute("""
|
||||||
SELECT COUNT(*) as duplicates
|
SELECT COUNT(*) as duplicates
|
||||||
@@ -570,6 +575,7 @@ class DatabaseService:
|
|||||||
conn.close()
|
conn.close()
|
||||||
return duplicates > 0
|
return duplicates > 0
|
||||||
else:
|
else:
|
||||||
|
# Migration already completed
|
||||||
conn.close()
|
conn.close()
|
||||||
return False
|
return False
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user