fix: correct composite key migration check

- Fix _check_composite_key_migration_needed to properly check if internalTransactionId is the primary key
- Use PRAGMA table_info pk flag instead of just checking column existence
- This ensures migration only runs when internalTransactionId is actually the primary key
This commit is contained in:
Elisiário Couto
2025-09-10 23:16:42 +01:00
parent 7dd33084f5
commit c0ee21d6fa

View File

@@ -551,10 +551,15 @@ class DatabaseService:
# Check if transactions table has the old primary key structure
cursor.execute("PRAGMA table_info(transactions)")
columns = cursor.fetchall()
column_names = [col[1] for col in columns]
# If we have internalTransactionId as primary key, migration is needed
if "internalTransactionId" in column_names:
# Check if internalTransactionId is the primary key (old structure)
internal_transaction_id_is_pk = any(
col[1] == "internalTransactionId" and col[5] == 1 # col[5] is pk flag
for col in columns
)
# If internalTransactionId is still the primary key, migration is needed
if internal_transaction_id_is_pk:
# Check if there are duplicate (accountId, transactionId) pairs
cursor.execute("""
SELECT COUNT(*) as duplicates
@@ -570,6 +575,7 @@ class DatabaseService:
conn.close()
return duplicates > 0
else:
# Migration already completed
conn.close()
return False