nikdoof/hg612-exporter
1
0
Fork 0
mirror of https://github.com/nikdoof/hg612-exporter.git synced 2025-12-13 18:22:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: reset gauge in-between collect() calls

Browse Source 
It looks like in the `collect()` loop the `dsl_status` gauge is latched to 1 with the current status label set
```go
c.status.WithLabelValues(
    c.host, c.identifier, status.DSLCfg.Status, status.DSLCfg.Modulation, status.DSLCfg.DataPath).Set(1)
```

However, this means that all historically seen statuses are latched to 1 and never reset to 0:
```
dsl_status{dataPath="",host="192.168.2.1",identifier="BT",modulation="",status="EstablishingLink"} 1
dsl_status{dataPath="",host="192.168.2.1",identifier="BT",modulation="",status="Initializing"} 1
dsl_status{dataPath="",host="192.168.2.1",identifier="BT",modulation="",status="NoSignal"} 1
```

Ideally in the `collect()` loop it would loop over all known status
values and set them to 0 for the ongoing publishes when the status has
changed. However, as a simpler workaround in this commit we just call
`.Reset()` on the gauge before the call to `.Set(1)` and that stops
publishing the metric label for the old statuses
This commit is contained in:
Dominic Evans
2020-07-03 11:24:12 +00:00
parent 2fe6ee5a32
commit baf88bdc78
1 changed files with 1 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
internal/metrics/dsl.go
View File

@@ -261,6 +261,7 @@ func (c dslMetricsCollector) collect() error {
return errors.Wrap(err, "error getting dsl status")
}
c.status.Reset()
c.status.WithLabelValues(c.host, c.identifier, status.DSLCfg.Status, status.DSLCfg.Modulation, status.DSLCfg.DataPath).Set(1)
c.upCurrRate.WithLabelValues(c.host, c.identifier).Set(float64(status.DSLCfg.UpCurrRate))