Switch iDRAC6 chart to k8s-at-home common chart (#27)

* Switch iDRAC6 chart to k8s-at-home common chart base

* Add test values and CT updates

* Update build workflows

* Switch to k3d

* Try and work out testing issue

* Try hard specifying the config

* Move ct to github folder

* Remove timeout

* Correct config file path

.github/ct.yaml

@@ -0,0 +1,10 @@
+remote: origin
+target-branch: master
+chart-dirs:
+- charts
+excluded-charts:
+chart-repos:
+- bitnami=https://charts.bitnami.com/bitnami
+- k8s-at-home-libraries=https://library-charts.k8s-at-home.com
+- k8s-at-home=https://k8s-at-home.com/charts
+- jetstack=https://charts.jetstack.io

.github/renovate.json5

@@ -0,0 +1,48 @@
+{
+  "enabled": true,
+  "dependencyDashboard": true,
+  "dependencyDashboardTitle": "Renovate Dashboard",
+  "suppressNotifications": ["prIgnoreNotification"],
+  "rebaseWhen": "conflicted",
+  "prConcurrentLimit": 5,
+  "helm-values": {
+    "enabled": false
+  },
+  "helmv3": {
+    "fileMatch": ["charts/.+/Chart\\.yaml$"]
+  },
+  "packageRules": [
+    {
+      "datasources": ["helm"],
+      "commitMessageTopic": "Helm chart {{depName}}",
+      "separateMinorPatch": true
+    },
+    {
+      "datasources": ["docker"],
+      "commitMessageTopic": "Docker image {{depName}}",
+      "separateMinorPatch": true
+    },
+    {
+      "commitMessagePrefix": "[{{{parentDir}}}]",
+      "branchTopic": "{{{parentDir}}}-{{{depNameSanitized}}}-{{{newMajor}}}{{#if isPatch}}.{{{newMinor}}}{{/if}}.x{{#if isLockfileUpdate}}-lockfile{{/if}}",
+      "updateTypes": ["major"],
+      "bumpVersion": "major",
+      "labels": ["dependency/major"],
+      "excludePackageNames": ["common"],
+    },
+    {
+      "updateTypes": ["minor"],
+      "bumpVersion": "minor",
+      "labels": ["dependency/minor"],
+      "excludePackageNames": ["common"],
+      "groupName": ["external minor dep"],
+    },
+    {
+      "updateTypes": ["patch"],
+      "bumpVersion": "patch",
+      "labels": ["dependency/patch"],
+      "excludePackageNames": ["common"],
+      "groupName": ["external patch dep"],
+    }
+  ]
+}

.github/workflows/lint-test.yaml

@@ -7,21 +7,43 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@v1
+        uses: actions/checkout@v2
+        with:
+          fetch-depth: 0
+
+      - name: Install Helm
+        uses: azure/setup-helm@v1
+        with:
+          version: v3.6.3
+
+      - uses: actions/setup-python@v2
+        with:
+          python-version: 3.7
+
+      - name: Set up chart-testing
+        uses: helm/chart-testing-action@v2.1.0
+
+      - name: Run chart-testing (list-changed)
+        id: list-changed
+        run: |
+          changed=$(ct list-changed)
+          if [[ -n "$changed" ]]; then
+            echo "::set-output name=changed::true"
+          fi
 
       - name: Run chart-testing (lint)
-        id: lint
-        uses: helm/chart-testing-action@v1.0.0-alpha.3
-        with:
-          command: lint
+        run: ct lint --config .github/ct.yaml
 
-      - name: Create kind cluster
-        uses: helm/kind-action@v1.0.0-alpha.3
+      - name: Create k3d cluster
+        uses: nolar/setup-k3d-k3s@v1
         with:
-          install_local_path_provisioner: true
-        if: steps.lint.outputs.changed == 'true'
+          version: v1.19
+        if: steps.list-changed.outputs.changed == 'true'
+
+      - name: Remove node taints
+        run: |
+          kubectl taint --all=true nodes node.cloudprovider.kubernetes.io/uninitialized- || true
 
       - name: Run chart-testing (install)
-        uses: helm/chart-testing-action@v1.0.0-alpha.3
-        with:
-          command: install
+        run: ct install --config .github/ct.yaml
+        if: steps.list-changed.outputs.changed == 'true'

.github/workflows/release.yaml

@@ -10,29 +10,23 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@v1
+        uses: actions/checkout@v2
+        with:
+          fetch-depth: 0
 
       - name: Configure Git
         run: |
           git config user.name "$GITHUB_ACTOR"
           git config user.email "$GITHUB_ACTOR@users.noreply.github.com"
 
-      # See https://github.com/helm/chart-releaser-action/issues/6
       - name: Install Helm
-        run: |
-          curl -sSLo get_helm.sh https://raw.githubusercontent.com/helm/helm/master/scripts/get
-          chmod 700 get_helm.sh
-          ./get_helm.sh
-          helm init --client-only
-
-      - name: Add dependency chart repos
-        run: |
-          helm repo add stable https://kubernetes-charts.storage.googleapis.com/
-          helm repo add incubator https://kubernetes-charts-incubator.storage.googleapis.com/
+        uses: azure/setup-helm@v1
+        with:
+          version: v3.4.0
 
       - name: Run chart-releaser
-        uses: helm/chart-releaser-action@v1.0.0-alpha.2
+        uses: helm/chart-releaser-action@v1.2.1
         with:
           charts_repo_url: https://nikdoof.github.io/helm-charts
         env:
-          CR_TOKEN: "${{ secrets.CR_TOKEN }}"
+          CR_TOKEN: "${{ secrets.CR_TOKEN }}"

charts/aaisp2mqtt/Chart.yaml

@@ -1,8 +1,8 @@
 apiVersion: v1
-appVersion: "0.3.0"
+appVersion: "0.3.1"
 description: Pulls data from the AAISP CHAOSv2 API into MQTT
 name: aaisp2mqtt
-version: 0.3.0
+version: 0.3.2
 keywords:
   - aaisp
   - mqtt

charts/aaisp2mqtt/templates/cronjob.yaml

@@ -18,7 +18,7 @@ spec:
   schedule: {{ .Values.cronjob.schedule | quote }}
   successfulJobsHistoryLimit: {{ .Values.cronjob.successfulJobsHistoryLimit }}
   failedJobsHistoryLimit: {{ .Values.cronjob.failedJobsHistoryLimit }}
-  concurrencyPolicy: Forbid
+  concurrencyPolicy: {{ .Values.cronjob.concurrencyPolicy }}
   {{- if .Values.cronjob.startingDeadlineSeconds }}
   startingDeadlineSeconds: {{ .Values.cronjob.startingDeadlineSeconds }}
   {{- end }}

charts/aaisp2mqtt/values.yaml

@@ -6,7 +6,7 @@ replicaCount: 1
 
 image:
   repository: nikdoof/aaisp2mqtt
-  tag: 0.3.0
+  tag: 0.3.1
   pullPolicy: IfNotPresent
   # imagePullSecrets: []
 
@@ -40,6 +40,7 @@ cronjob:
   successfulJobsHistoryLimit: 3
   failedJobsHistoryLimit: 1
   # startingDeadlineSeconds: 10
+  concurrencyPolicy: Allow
 
 resources: {}
   # We usually recommend not to specify default resources and to leave this as a conscious

charts/idrac6/.helmignore

@@ -0,0 +1,23 @@
+# Patterns to ignore when building packages.
+# This supports shell glob matching, relative path matching, and
+# negation (prefixed with !). Only one pattern per line.
+.DS_Store
+# Common VCS dirs
+.git/
+.gitignore
+.bzr/
+.bzrignore
+.hg/
+.hgignore
+.svn/
+# Common backup files
+*.swp
+*.bak
+*.tmp
+*~
+# Various IDEs
+.project
+.idea/
+*.tmproj
+# OWNERS file for Kubernetes
+OWNERS

charts/idrac6/Chart.yaml

@@ -0,0 +1,18 @@
+apiVersion: v2
+appVersion: "0.5.0"
+description: iDRAC 6 web interface and VNC proxy
+name: idrac6
+version: 1.0.0
+kubeVersion: ">=1.16.0-0"
+keywords:
+  - idrac6
+home: https://github.com/nikdoof/helm-charts/tree/master/charts/idrac6/
+sources:
+  - https://github.com/DomiStyle/docker-idrac6
+maintainers:
+  - name: nikdoof
+    email: andy@tensixtyone.com
+dependencies:
+  - name: common
+    repository: https://library-charts.k8s-at-home.com
+    version: 4.2.0

charts/idrac6/README.md

@@ -0,0 +1,121 @@
+# idrac6
+
+![Version: 1.0.0](https://img.shields.io/badge/Version-1.0.0-informational?style=flat-square) ![AppVersion: 0.5.0](https://img.shields.io/badge/AppVersion-0.5.0-informational?style=flat-square)
+
+iDRAC 6 web interface and VNC proxy
+
+**This chart is not maintained by the upstream project and any issues with the chart should be raised [here](https://github.com/k8s-at-home/charts/issues/new/choose)**
+
+## Source Code
+
+* <https://github.com/DomiStyle/docker-idrac6>
+
+## Requirements
+
+Kubernetes: `>=1.16.0-0`
+
+## Dependencies
+
+| Repository | Name | Version |
+|------------|------|---------|
+| https://library-charts.k8s-at-home.com | common | 4.2.0 |
+
+## TL;DR
+
+```console
+helm repo add nikdoof-helm-charts https://nikdoof.github.io/helm-charts/
+helm repo update
+helm install idrac6 nikdoof-helm-charts/idrac6
+```
+
+## Installing the Chart
+
+To install the chart with the release name `idrac6`
+
+```console
+helm install idrac6 nikdoof-helm-charts/idrac6
+```
+
+## Uninstalling the Chart
+
+To uninstall the `idrac6` deployment
+
+```console
+helm uninstall idrac6
+```
+
+The command removes all the Kubernetes components associated with the chart **including persistent volumes** and deletes the release.
+
+## Configuration
+
+Read through the [values.yaml](./values.yaml) file. It has several commented out suggested values.
+Other values may be used from the [values.yaml](https://github.com/k8s-at-home/library-charts/tree/main/charts/stable/common/values.yaml) from the [common library](https://github.com/k8s-at-home/library-charts/tree/main/charts/stable/common).
+
+Specify each parameter using the `--set key=value[,key=value]` argument to `helm install`.
+
+```console
+helm install idrac6 \
+  --set env.IDRAC_HOST="idrac"\
+    nikdoof-helm-charts/idrac6
+```
+
+Alternatively, a YAML file that specifies the values for the above parameters can be provided while installing the chart.
+
+```console
+helm install idrac6 nikdoof-helm-charts/idrac6 -f values.yaml
+```
+
+## Custom configuration
+
+N/A
+
+## Values
+
+**Important**: When deploying an application Helm chart you can add more values from our common library chart [here](https://github.com/k8s-at-home/library-charts/tree/main/charts/stable/common)
+
+| Key | Type | Default | Description |
+|-----|------|---------|-------------|
+| env | object | See below | environment variables. See more environment variables in the [idrac6 documentation](https://github.com/DomiStyle/docker-idrac6). |
+| env.IDRAC_HOST | string | `nil` | iDRAC hostname to connect to |
+| env.IDRAC_KEYCODE_HACK | string | `"false"` | Enable keycode hack |
+| env.IDRAC_PASSWORD | string | `"calvin"` | iDRAC password to use |
+| env.IDRAC_PORT | int | `443` | iDRAC HTTP port |
+| env.IDRAC_USER | string | `"root"` | iDRAC Username to use |
+| image.pullPolicy | string | `"IfNotPresent"` | image pull policy |
+| image.repository | string | `"domistyle/idrac6"` | image repository |
+| image.tag | string | `"v0.5"` | image tag |
+| ingress.main | object | See values.yaml | Enable and configure ingress settings for the chart under this key. |
+| persistence | object | See values.yaml | Configure persistence settings for the chart under this key. |
+| persistence.app | object | See values.yaml | allows caching of the required JARs in persistent storage, and allows for quicker connections. |
+| persistence.screenshots | object | See values.yaml | Screenshots took from the iDRAC client. |
+| persistence.vmedia | object | See values.yaml | Virtual media that can be connected to the iDRAC. |
+| service | object | See values.yaml | Configures service settings for the chart. |
+
+## Changelog
+
+All notable changes to this application Helm chart will be documented in this file but does not include changes from our common library. To read those click [here](https://github.com/k8s-at-home/library-charts/tree/main/charts/stable/common#changelog).
+
+The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
+
+### [1.0.0]
+
+#### Added
+
+- N/A
+
+#### Changed
+
+- Switched to the [k8s-at-home](https://docs.k8s-at-home.com/) common chart as a base.
+
+#### Removed
+
+- N/A
+
+[1.0.0]: #100
+
+## Support
+
+- Open an [issue](https://github.com/nikdoof/helm-charts/issues/new/choose)
+
+----------------------------------------------
+Autogenerated from chart metadata using [helm-docs v1.5.0](https://github.com/norwoodj/helm-docs/releases/v1.5.0)

charts/idrac6/README.md.gotmpl

@@ -0,0 +1,143 @@
+{{- define "custom.repository.organization" -}}
+nikdoof-helm-charts
+{{- end -}}
+
+{{- define "custom.repository.url" -}}
+https://github.com/nikdoof/helm-charts
+{{- end -}}
+
+{{- define "custom.helm.url" -}}
+https://nikdoof.github.io/helm-charts/
+{{- end -}}
+
+{{- define "custom.helm.path" -}}
+{{ template "custom.repository.organization" . }}/{{ template "chart.name" . }}
+{{- end -}}
+
+{{- define "custom.notes" -}}
+**This chart is not maintained by the upstream project and any issues with the chart should be raised [here](https://github.com/k8s-at-home/charts/issues/new/choose)**
+{{- end -}}
+
+{{- define "custom.requirements" -}}
+## Requirements
+
+{{ template "chart.kubeVersionLine" . }}
+{{- end -}}
+
+{{- define "custom.dependencies" -}}
+## Dependencies
+
+{{ template "chart.requirementsTable" . }}
+{{- end -}}
+
+{{- define "custom.install.tldr" -}}
+## TL;DR
+
+```console
+helm repo add {{ template "custom.repository.organization" . }} {{ template "custom.helm.url" . }}
+helm repo update
+helm install {{ template "chart.name" . }} {{ template "custom.helm.path" . }}
+```
+{{- end -}}
+
+{{- define "custom.install" -}}
+## Installing the Chart
+
+To install the chart with the release name `{{ template "chart.name" . }}`
+
+```console
+helm install {{ template "chart.name" . }} {{ template "custom.helm.path" . }}
+```
+{{- end -}}
+
+{{- define "custom.uninstall" -}}
+## Uninstalling the Chart
+
+To uninstall the `{{ template "chart.name" . }}` deployment
+
+```console
+helm uninstall {{ template "chart.name" . }}
+```
+
+The command removes all the Kubernetes components associated with the chart **including persistent volumes** and deletes the release.
+{{- end -}}
+
+{{- define "custom.configuration.header" -}}
+## Configuration
+{{- end -}}
+
+{{- define "custom.configuration.readValues" -}}
+Read through the [values.yaml](./values.yaml) file. It has several commented out suggested values.
+Other values may be used from the [values.yaml](https://github.com/k8s-at-home/library-charts/tree/main/charts/stable/common/values.yaml) from the [common library](https://github.com/k8s-at-home/library-charts/tree/main/charts/stable/common).
+{{- end -}}
+
+{{- define "custom.configuration.example.set" -}}
+Specify each parameter using the `--set key=value[,key=value]` argument to `helm install`.
+
+```console
+helm install {{ template "chart.name" . }} \
+  --set env.IDRAC_HOST="idrac"\
+    {{ template "custom.helm.path" . }}
+```
+{{- end -}}
+
+{{- define "custom.configuration.example.file" -}}
+Alternatively, a YAML file that specifies the values for the above parameters can be provided while installing the chart.
+
+```console
+helm install {{ template "chart.name" . }} {{ template "custom.helm.path" . }} -f values.yaml
+```
+{{- end -}}
+
+{{- define "custom.valuesSection" -}}
+## Values
+
+**Important**: When deploying an application Helm chart you can add more values from our common library chart [here](https://github.com/k8s-at-home/library-charts/tree/main/charts/stable/common)
+
+{{ template "chart.valuesTable" . }}
+{{- end -}}
+
+{{- define "custom.support" -}}
+## Support
+
+- Open an [issue](https://github.com/nikdoof/helm-charts/issues/new/choose)
+{{- end -}}
+
+{{ template "chart.header" . }}
+
+{{ template "chart.versionBadge" . }}{{ template "chart.typeBadge" . }}{{ template "chart.appVersionBadge" . }}
+
+{{ template "chart.description" . }}
+
+{{ template "custom.notes" . }}
+
+{{ template "chart.sourcesSection" . }}
+
+{{ template "custom.requirements" . }}
+
+{{ template "custom.dependencies" . }}
+
+{{ template "custom.install.tldr" . }}
+
+{{ template "custom.install" . }}
+
+{{ template "custom.uninstall" . }}
+
+{{ template "custom.configuration.header" . }}
+
+{{ template "custom.configuration.readValues" . }}
+
+{{ template "custom.configuration.example.set" . }}
+
+{{ template "custom.configuration.example.file" . }}
+
+{{ template "custom.custom.configuration" . }}
+
+{{ template "custom.valuesSection" . }}
+
+{{ template "custom.changelog" . }}
+
+{{ template "custom.support" . }}
+
+{{ template "helm-docs.versionFooter" . }}
+{{ "" }}

charts/idrac6/README_CHANGELOG.md.gotmpl

@@ -0,0 +1,27 @@
+{{- define "custom.changelog.header" -}}
+## Changelog
+{{- end -}}
+
+{{- define "custom.changelog" -}}
+{{ template "custom.changelog.header" . }}
+
+All notable changes to this application Helm chart will be documented in this file but does not include changes from our common library. To read those click [here](https://github.com/k8s-at-home/library-charts/tree/main/charts/stable/common#changelog).
+
+The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
+
+### [1.0.0]
+
+#### Added
+
+- N/A
+
+#### Changed
+
+- Switched to the [k8s-at-home](https://docs.k8s-at-home.com/) common chart as a base.
+
+#### Removed
+
+- N/A
+
+[1.0.0]: #100
+{{- end -}}

charts/idrac6/README_CONFIG.md.gotmpl

@@ -0,0 +1,9 @@
+{{- define "custom.custom.configuration.header" -}}
+## Custom configuration
+{{- end -}}
+
+{{- define "custom.custom.configuration" -}}
+{{ template "custom.custom.configuration.header" . }}
+
+N/A
+{{- end -}}

charts/idrac6/ci/test-values.yaml

@@ -0,0 +1,3 @@
+---
+env:
+  IDRAC_HOST: test

charts/idrac6/templates/NOTES.txt

@@ -0,0 +1 @@
+{{- include "common.notes.defaultNotes" . -}}

charts/idrac6/templates/common.yaml

@@ -0,0 +1 @@
+{{ include "common.all" . }}

charts/idrac6/values.yaml

@@ -0,0 +1,63 @@
+#
+# IMPORTANT NOTE
+#
+# This chart inherits from our common library chart. You can check the default values/options here:
+# https://github.com/k8s-at-home/library-charts/tree/main/charts/stable/common/values.yaml
+#
+
+image:
+  # -- image repository
+  repository: domistyle/idrac6
+  # -- image tag
+  tag: v0.5
+  # -- image pull policy
+  pullPolicy: IfNotPresent
+
+# -- environment variables. See more environment variables in the [idrac6 documentation](https://github.com/DomiStyle/docker-idrac6).
+# @default -- See below
+env:
+  # -- iDRAC hostname to connect to
+  IDRAC_HOST:
+  # -- iDRAC Username to use
+  IDRAC_USER: root
+  # -- iDRAC password to use
+  IDRAC_PASSWORD: calvin
+  # -- iDRAC HTTP port
+  IDRAC_PORT: 443
+  # -- Enable keycode hack
+  IDRAC_KEYCODE_HACK: 'false'
+
+# -- Configures service settings for the chart.
+# @default -- See values.yaml
+service:
+  main:
+    ports:
+      http:
+        port: 5800
+      vnc:
+        port: 5900
+
+ingress:
+  # -- Enable and configure ingress settings for the chart under this key.
+  # @default -- See values.yaml
+  main:
+    enabled: false
+
+# -- Configure persistence settings for the chart under this key.
+# @default -- See values.yaml
+persistence:
+  # -- allows caching of the required JARs in persistent storage, and allows for quicker connections.
+  # @default -- See values.yaml
+  app:
+    enabled: false
+    mountPath: /app
+  # -- Virtual media that can be connected to the iDRAC.
+  # @default -- See values.yaml
+  vmedia:
+    enabled: false
+    mountPath: /vmedia
+  # -- Screenshots took from the iDRAC client.
+  # @default -- See values.yaml
+  screenshots:
+    enabled: false
+    mountPath: /screenshots

charts/vsphere-influxdb-go/Chart.yaml

@@ -2,7 +2,7 @@ apiVersion: v1
 appVersion: "0.8.5"
 description: Collect VMware vCenter and ESXi performance metrics and send them to InfluxDB
 name: vsphere-influxdb-go
-version: 0.2.0
+version: 0.2.2
 keywords:
   - vsphere
   - influxdb

charts/vsphere-influxdb-go/values.yaml

@@ -42,11 +42,11 @@ cronjob:
 ## add them.
 ##
 config:
-  Domain: ".lab"
+  Domain: ""
   RemoveHostDomainName: false
   Interval: 60
-  VCenters: {}
-  InfluxDB: {}
+  VCenters: []
+  InfluxDB: []
   Metrics:
   - ObjectType:
     - VirtualMachine

charts/zigbee2mqttassistant/Chart.yaml

@@ -1,8 +1,8 @@
 apiVersion: v1
-appVersion: "0.3.165"
+appVersion: "0.3.178"
 description: A web GUI for Zigbee2Mqtt
 name: zigbee2mqttassistant
-version: 0.1.0
+version: 0.1.1
 keywords:
   - zigbee
   - mqtt

charts/zigbee2mqttassistant/templates/secrets.yaml

@@ -1,9 +1,8 @@
----
 {{- if and (and (not (.Values.existingSecretName)) (.Values.z2ma.username)) (.Values.z2ma.password) }}
 apiVersion: v1
 kind: Secret
 metadata:
-  name: zigbee2mqttassistant-secret
+  name: {{ include "zigbee2mqttassistant.name" . }}-secret
   labels:
     app.kubernetes.io/name: {{ include "zigbee2mqttassistant.name" . }}
     helm.sh/chart: {{ include "zigbee2mqttassistant.chart" . }}

charts/zigbee2mqttassistant/values.yaml

@@ -6,7 +6,7 @@ replicaCount: 1
 
 image:
   repository: carldebilly/zigbee2mqttassistant
-  tag: 0.3.165
+  tag: 0.3.178
   pullPolicy: IfNotPresent
 
 imagePullSecrets: []

ct.yaml

@@ -1,2 +0,0 @@
-chart-dirs:
-  - charts