Using modern Objective-C

This commit is contained in:
michael starke
2016-09-05 12:17:13 +02:00
parent f0d4b2f835
commit e06cf82368
2 changed files with 8 additions and 8 deletions

View File

@@ -83,7 +83,7 @@
KPKGroup *targetGroup = targetItem;
BOOL validTarget = YES;
MPDocument *document = [[[outlineView window] windowController] document];
MPDocument *document = outlineView.window.windowController.document;
/* Dragging Groups */
if(draggedGroup) {
self.localDraggedGroup = [document findGroup:draggedGroup.uuid];
@@ -177,18 +177,18 @@
/* Cleanup old stuff */
NSArray *types = [pasteboard types];
if([types count] > 1 || [types count] == 0) {
if(types.count > 1 || types.count == 0) {
return NO;
}
NSString *draggedType = [types lastObject];
NSString *draggedType = types.lastObject;
if([draggedType isEqualToString:KPKGroupUTI]) {
// dragging group
NSArray *groups = [pasteboard readObjectsForClasses:@[[KPKGroup class]] options:nil];
if([groups count] != 1) {
if(groups.count != 1) {
return NO;
}
*group = [groups lastObject];
*group = groups.lastObject;
return YES;
}
else if([draggedType isEqualToString:KPKEntryUTI]) {
@@ -196,7 +196,7 @@
if([entries count] != 1) {
return NO; // NO entry readable
}
*entry = [entries lastObject];
*entry = entries.lastObject;
return YES;
}
return NO;

View File

@@ -30,7 +30,7 @@
NSString *extension = [self.document fileNameExtensionForType:uti saveOperation:NSSaveOperation];
NSString *title = [NSString stringWithFormat:@"%@ (%@)", description, extension];
[menu addItemWithTitle:title action:@selector(setFileType:) keyEquivalent:@""];
NSMenuItem *item = [[menu itemArray] lastObject];
NSMenuItem *item = menu.itemArray.lastObject;
item.target = self;
item.representedObject = uti;
}
@@ -81,7 +81,7 @@
}
- (void)_updateNote {
NSString *uti = [[self.fileTypePopupButton selectedItem] representedObject];
NSString *uti = self.fileTypePopupButton.selectedItem.representedObject;
BOOL showInfoText = (self.document.tree.minimumType == KPKDatabaseTypeXml && [uti isEqualToString:MPLegacyDocumentUTI]);
self.infoTextField.hidden = !showInfoText;
}