Fix and improve nightly builds (#1307)

* ci: (nightly) bump TransformerKit to fix compile

Fixes build issue with Xcode 15 by raising minimum deployment target
to 10.13

* ci: (nightly) bump dependencies to latest versions

This ensures the build no longer fails with error code 65

* ci: (nightly) use github_token for carthage rate limit

If we don't use the token the build can sometimes fail as it is
rate limited, this ensures we can build more with less restrictions.

* ci: (nightly) add empty sign identity

* ci: (nightly) add code sign entitlements flag

* build: make copyfiles first task to fix build cycle

* ci: (nightly) bump gh action checkout to v4

* ci: (nightly) format github actions yaml

* ci: (nightly) bump agent to use macos-latest

* ci: (nightly) bump gh-release action to v2

* ci: fix algorithm name in hash

.github/workflows/nightly.yml

@@ -6,31 +6,33 @@ on:
   #pull_request:
   #  branches: [ master ]
   schedule:
-    - cron:  '0 23 * * *'
+    - cron: "0 23 * * *"
 
   workflow_dispatch:
 
 jobs:
   nightly:
-    runs-on: macos-12
+    runs-on: macos-latest
 
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
         with:
           submodules: recursive
 
       - name: Bootstrap Carthage
+        env:
+          GITHUB_ACCESS_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         run: carthage bootstrap --platform macOS
 
       - name: Install xcpretty
         run: gem install xcpretty --no-document --quiet
-      
+
       - name: Build
         run: |
           set -o pipefail
           xcodebuild clean
-          xcodebuild build -configuration release -project MacPass.xcodeproj  -scheme MacPass CODE_SIGNING_REQUIRED=NO -derivedDataPath ./build | xcpretty -c
-      
+          xcodebuild build -configuration release -project MacPass.xcodeproj -scheme MacPass CODE_SIGN_IDENTITY="" CODE_SIGNING_REQUIRED=NO CODE_SIGN_ENTITLEMENTS="" -derivedDataPath ./build | xcpretty -c
+
       - name: Export Localizations
         run: |
           xcodebuild -project MacPass.xcodeproj -exportLocalizations -localizationPath Localisations -exportLanguage de 
@@ -42,20 +44,20 @@ jobs:
           xcodebuild -project MacPass.xcodeproj -exportLocalizations -localizationPath Localisations -exportLanguage ru
           xcodebuild -project MacPass.xcodeproj -exportLocalizations -localizationPath Localisations -exportLanguage sv-SE
           xcodebuild -project MacPass.xcodeproj -exportLocalizations -localizationPath Localisations -exportLanguage zh-Hans
-      
+
       - name: Zip Localizations
         run: zip -9ry Localisations.zip Localisations
-      
+
       - name: Package Release
         run: |
           cd ./build/Build/Products/Release
           zip -9ry MacPass-continuous.zip MacPass.app
-      
-      - name: Create MD5 Hash
+
+      - name: Create SHA256 Hash
         run: |
           cd ./build/Build/Products/Release
           shasum -a 256 MacPass-continuous.zip > MacPass-continuous.zip.sha256
-     
+
       #- name: Release
       #  uses: eine/tip@master
       #  with:
@@ -65,13 +67,13 @@ jobs:
       #      Localisations.zip
       #      ./build/Build/Products/Release/MacPass-continuous.zip
       #      ./build/Build/Products/Release/MacPass-continuous.zip.sha256
-      
+
       - name: Release
-        uses: softprops/action-gh-release@v1
+        uses: softprops/action-gh-release@v2
         if: startsWith(github.ref, 'refs/tags/')
         with:
           tag_name: continuous
           files: |
             Localisations.zip
             ./build/Build/Products/Release/MacPass-continuous.zip
-            ./build/Build/Products/Release/MacPass-continuous.zip.sha256
+            ./build/Build/Products/Release/MacPass-continuous.zip.sha256

Cartfile

@@ -1,4 +1,4 @@
 binary "https://sparkle-project.org/Carthage/Sparkle.json"
-github "MacPass/TransformerKit" "a8b5bb73cc327ec6798569b865c32fec5eb2289f"
-github "MacPass/KeePassKit" ~> 3.2.0
-github "mstarke/HNHUi" ~> 6.0
+github "MacPass/TransformerKit" "3232b04c568df7f98b33ceb21a2090a9ccbc2065"
+github "MacPass/KeePassKit" ~> 3.3.2
+github "mstarke/HNHUi" ~> 6.0.1

Cartfile.resolved

@@ -1,5 +1,5 @@
-binary "https://sparkle-project.org/Carthage/Sparkle.json" "2.3.0"
-github "MacPass/KeePassKit" "3.2.1"
-github "MacPass/KissXML" "933f04fe5ad95c2be07ec0c2f801e140007f20fa"
-github "MacPass/TransformerKit" "a8b5bb73cc327ec6798569b865c32fec5eb2289f"
-github "mstarke/HNHUi" "6.0"
+binary "https://sparkle-project.org/Carthage/Sparkle.json" "2.6.4"
+github "MacPass/KeePassKit" "3.3.2"
+github "MacPass/KissXML" "503fc012b73a4507965019720cbf1c157e849657"
+github "MacPass/TransformerKit" "3232b04c568df7f98b33ceb21a2090a9ccbc2065"
+github "mstarke/HNHUi" "6.0.1"

MacPass.xcodeproj/project.pbxproj

@@ -2010,11 +2010,11 @@
 			isa = PBXNativeTarget;
 			buildConfigurationList = 4C77E38015B84A240093A587 /* Build configuration list for PBXNativeTarget "MacPass" */;
 			buildPhases = (
+				4CC5D36618A1332000AF7FA8 /* CopyFiles */,
 				4C77E35E15B84A240093A587 /* Sources */,
 				4C77E35F15B84A240093A587 /* Frameworks */,
 				4C77E36015B84A240093A587 /* Resources */,
 				4C44DB1B1C08999F00774EB3 /* Versioning */,
-				4CC5D36618A1332000AF7FA8 /* CopyFiles */,
 			);
 			buildRules = (
 			);