From 6acaf5c0f11f0c7a25296a0d1db570ef882ebb10 Mon Sep 17 00:00:00 2001 From: Dreddit Web User Date: Wed, 9 Feb 2011 12:43:19 +0000 Subject: [PATCH 1/3] Add some better error checking and retrying around Corporation detail import --- eve_api/tasks/alliance.py | 1 - eve_api/tasks/corporation.py | 8 +++++++- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/eve_api/tasks/alliance.py b/eve_api/tasks/alliance.py index e7f833b..ba19b98 100644 --- a/eve_api/tasks/alliance.py +++ b/eve_api/tasks/alliance.py @@ -36,7 +36,6 @@ def import_alliance_details(): for corp in alliance['memberCorporations']: if int(corp['corporationID']) not in corplist: import_corp_details.delay(corp['corporationID']) - pass validcorps.append(int(corp['corporationID'])) delcorps = set(corplist) - set(validcorps) diff --git a/eve_api/tasks/corporation.py b/eve_api/tasks/corporation.py index 437a163..1da351b 100644 --- a/eve_api/tasks/corporation.py +++ b/eve_api/tasks/corporation.py @@ -4,6 +4,7 @@ from xml.dom import minidom from celery.decorators import task from eve_proxy.models import CachedDocument +from eve_proxy.exceptions imort DocumentRetrievalError from eve_api.models import EVEPlayerCorporation, EVEPlayerCharacter, EVEPlayerAlliance from eve_api.utils import basic_xml_parse_doc from eve_api.tasks.character import import_eve_character @@ -43,7 +44,12 @@ def import_corp_details_func(corp_id, log=logging.getLogger(__name__)): corpobj, created = EVEPlayerCorporation.objects.get_or_create(id=corp_id) if created or not corpobj.api_last_updated or corpobj.api_last_updated < (datetime.utcnow() - timedelta(hours=12)): - doc = CachedDocument.objects.api_query('/corp/CorporationSheet.xml.aspx', {'corporationID': corp_id}) + try: + doc = CachedDocument.objects.api_query('/corp/CorporationSheet.xml.aspx', {'corporationID': corp_id}) + except DocumentRetrievalError, exc: + logger.error('Error retrieving CorporationSheet.xml.aspx for ID %s - %s' % (corp_id, exc)) + raise APIAccessException + d = basic_xml_parse_doc(doc)['eveapi'] if 'error' in d: From b77aa93c4f2336d731dc88c682f8b17e6baf6400 Mon Sep 17 00:00:00 2001 From: Dreddit Web User Date: Wed, 9 Feb 2011 12:43:56 +0000 Subject: [PATCH 2/3] Add the correct URL --- api/urls.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/api/urls.py b/api/urls.py index c535a06..66c6e04 100755 --- a/api/urls.py +++ b/api/urls.py @@ -16,7 +16,7 @@ eveapiproxy_resource = Resource(handler=EveAPIProxyHandler, **apikeyauth) optimer_resource = Resource(handler=OpTimerHandler, **apikeyauth) blacklist_resource = Resource(handler=BlacklistHandler, **apikeyauth) characters_resource = Resource(handler=CharacterHandler, **apikeyauth) -announce_resource = Resource(handler=CharacterHandler, **apikeyauth) +announce_resource = Resource(handler=AnnounceHandler, **apikeyauth) urlpatterns = patterns('', url(r'^user/$', user_resource), From 3c9a8bc3f045134c30b6c462e49bf1860c35cbac Mon Sep 17 00:00:00 2001 From: Dreddit Web User Date: Wed, 9 Feb 2011 12:44:11 +0000 Subject: [PATCH 3/3] Link usernames from the group list --- templates/groups/group_admin.html | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/templates/groups/group_admin.html b/templates/groups/group_admin.html index 9b33f37..ef0b38c 100644 --- a/templates/groups/group_admin.html +++ b/templates/groups/group_admin.html @@ -10,7 +10,7 @@ {% for user, chars, status in member_list %} - +
Member UsernameCharactersStatusActions
{{ user.username }}
{{ user.username }} {{ chars }} {{ status }} Kick Member @@ -28,7 +28,7 @@ {% for req in requests %} - +
UsernameReasonStatusCreated DateActions
{{ req.user }}
{{ req.user }} {{ req.reason }} {{ req.get_status_description }} {{ req.created_date }}