diff --git a/crates/caldav/src/calendar_object/resource.rs b/crates/caldav/src/calendar_object/resource.rs index 5834dc4..b58cec6 100644 --- a/crates/caldav/src/calendar_object/resource.rs +++ b/crates/caldav/src/calendar_object/resource.rs @@ -69,7 +69,6 @@ impl Resource for CalendarObjectResource { } fn get_displayname(&self) -> Option<&str> { - // TODO: Extract summary from object None } diff --git a/crates/carddav/src/addressbook/methods/get.rs b/crates/carddav/src/addressbook/methods/get.rs index 333e0e7..ca5d881 100644 --- a/crates/carddav/src/addressbook/methods/get.rs +++ b/crates/carddav/src/addressbook/methods/get.rs @@ -47,7 +47,7 @@ pub async fn route_get( let mut resp = Response::builder().status(StatusCode::OK); let hdrs = resp.headers_mut().unwrap(); hdrs.typed_insert(ContentType::from_str("text/vcard").unwrap()); - let filename = format!("{}_{}.vcf", principal, addressbook_id); + let filename = format!("{principal}_{addressbook_id}.vcf"); let filename = utf8_percent_encode(&filename, CONTROLS); hdrs.insert( header::CONTENT_DISPOSITION, diff --git a/crates/carddav/src/addressbook/methods/mkcol.rs b/crates/carddav/src/addressbook/methods/mkcol.rs index e1fbc2e..225ce0f 100644 --- a/crates/carddav/src/addressbook/methods/mkcol.rs +++ b/crates/carddav/src/addressbook/methods/mkcol.rs @@ -88,15 +88,8 @@ pub async fn route_mkcol( } } - match addr_store.insert_addressbook(addressbook).await { - // TODO: The spec says we should return a mkcol-response. - // However, it works without one but breaks on iPadOS when using an empty one :) - Ok(()) => Ok(StatusCode::CREATED.into_response()), - Err(err) => { - dbg!(err.to_string()); - Err(err.into()) - } - } + addr_store.insert_addressbook(addressbook).await?; + Ok(StatusCode::CREATED.into_response()) } #[cfg(test)] diff --git a/crates/frontend/js-components/lib/create-addressbook-form.ts b/crates/frontend/js-components/lib/create-addressbook-form.ts index 6798e86..82e4145 100644 --- a/crates/frontend/js-components/lib/create-addressbook-form.ts +++ b/crates/frontend/js-components/lib/create-addressbook-form.ts @@ -80,7 +80,6 @@ export class CreateAddressbookForm extends LitElement { alert("Empty displayname") return } - // TODO: Escape user input: There's not really a security risk here but would be nicer await this.client.createDirectory(`/principal/${this.principal || this.user}/${this.addr_id}`, { data: ` diff --git a/crates/store/src/auth/principal_type.rs b/crates/store/src/auth/principal_type.rs index 271f239..89bc24e 100644 --- a/crates/store/src/auth/principal_type.rs +++ b/crates/store/src/auth/principal_type.rs @@ -13,7 +13,7 @@ pub enum PrincipalType { Resource, Room, Unknown, - // TODO: X-Name, IANA-token + // X-Name, IANA-token } impl TryFrom<&str> for PrincipalType {