minor improvements to rustical_xml errors

crates/xml/src/de.rs

@@ -1,11 +1,9 @@
-use quick_xml::name::Namespace;
+use quick_xml::events::{BytesStart, Event};
 use quick_xml::name::ResolveResult;
 use std::io::BufRead;
 pub use xml_derive::XmlDeserialize;
 pub use xml_derive::XmlDocument;
 
-use quick_xml::events::{BytesStart, Event};
-
 use crate::XmlDeError;
 use crate::XmlRootTag;
 
@@ -69,7 +67,7 @@ impl<T: XmlRootTag + XmlDeserialize> XmlDocument for T {
 
                     return Self::deserialize(&mut reader, &start, empty);
                 }
-                _ => return Err(XmlDeError::UnknownError),
+                _ => return Err(XmlDeError::UnsupportedEvent("unknown, todo")),
             };
         }
     }

crates/xml/src/error.rs

@@ -6,8 +6,6 @@ pub enum XmlDeError {
     QuickXmlError(#[from] quick_xml::Error),
     #[error(transparent)]
     QuickXmlAttrError(#[from] quick_xml::events::attributes::AttrError),
-    #[error("Unknown error")]
-    UnknownError,
     #[error("Invalid tag [{0}]{1}. Expected [{2}]{3}")]
     InvalidTag(String, String, String, String),
     #[error("Missing field {0}")]

crates/xml/src/value.rs

@@ -57,7 +57,7 @@ impl Value for &str {
         self.to_string()
     }
 
-    fn deserialize(val: &str) -> Result<Self, XmlDeError> {
+    fn deserialize(_val: &str) -> Result<Self, XmlDeError> {
         Err(XmlDeError::Other("TODO: Handle this error".to_owned()))
     }
 }