Rename events to calendar objects

This commit is contained in:
Lennart
2024-10-03 15:59:19 +02:00
parent 24419397c3
commit 6eaaae37b3
24 changed files with 394 additions and 44 deletions

View File

@@ -25,7 +25,7 @@ pub struct CalendarMultigetRequest {
href: Vec<String>,
}
pub async fn get_events_calendar_multiget<C: CalendarStore + ?Sized>(
pub async fn get_objects_calendar_multiget<C: CalendarStore + ?Sized>(
cal_query: &CalendarMultigetRequest,
prefix: &str,
principal: &str,
@@ -68,8 +68,8 @@ pub async fn handle_calendar_multiget<C: CalendarStore + ?Sized>(
cid: &str,
cal_store: &RwLock<C>,
) -> Result<MultistatusElement<PropstatWrapper<CalendarObjectProp>, String>, Error> {
let events =
get_events_calendar_multiget(&cal_multiget, prefix, principal, cid, cal_store).await?;
let objects =
get_objects_calendar_multiget(&cal_multiget, prefix, principal, cid, cal_store).await?;
let props = match cal_multiget.prop {
PropfindType::Allprop => {
@@ -84,10 +84,10 @@ pub async fn handle_calendar_multiget<C: CalendarStore + ?Sized>(
let props: Vec<&str> = props.iter().map(String::as_str).collect();
let mut responses = Vec::new();
for event in events {
let path = format!("{}/{}", req.path(), event.get_uid());
for object in objects {
let path = format!("{}/{}", req.path(), object.get_uid());
responses.push(
CalendarObjectResource::from(event)
CalendarObjectResource::from(object)
.propfind(prefix, &path, props.clone())
.await?,
);

View File

@@ -160,7 +160,7 @@ pub struct CalendarQueryRequest {
timezone: Option<String>,
}
pub async fn get_events_calendar_query<C: CalendarStore + ?Sized>(
pub async fn get_objects_calendar_query<C: CalendarStore + ?Sized>(
cal_query: &CalendarQueryRequest,
principal: &str,
cid: &str,
@@ -181,7 +181,7 @@ pub async fn handle_calendar_query<C: CalendarStore + ?Sized>(
cid: &str,
cal_store: &RwLock<C>,
) -> Result<MultistatusElement<PropstatWrapper<CalendarObjectProp>, String>, Error> {
let events = get_events_calendar_query(&cal_query, principal, cid, cal_store).await?;
let objects = get_objects_calendar_query(&cal_query, principal, cid, cal_store).await?;
let props = match cal_query.prop {
PropfindType::Allprop => {
@@ -196,10 +196,10 @@ pub async fn handle_calendar_query<C: CalendarStore + ?Sized>(
let props: Vec<&str> = props.iter().map(String::as_str).collect();
let mut responses = Vec::new();
for event in events {
let path = format!("{}/{}", req.path(), event.get_uid());
for object in objects {
let path = format!("{}/{}", req.path(), object.get_uid());
responses.push(
CalendarObjectResource::from(event)
CalendarObjectResource::from(object)
.propfind(prefix, &path, props.clone())
.await?,
);

View File

@@ -63,24 +63,24 @@ pub async fn handle_sync_collection<C: CalendarStore + ?Sized>(
let props: Vec<&str> = props.iter().map(String::as_str).collect();
let old_synctoken = parse_synctoken(&sync_collection.sync_token).unwrap_or(0);
let (new_events, deleted_events, new_synctoken) = cal_store
let (new_objects, deleted_objects, new_synctoken) = cal_store
.read()
.await
.sync_changes(principal, cid, old_synctoken)
.await?;
let mut responses = Vec::new();
for event in new_events {
let path = format!("{}/{}", req.path(), event.get_uid());
for object in new_objects {
let path = format!("{}/{}", req.path(), object.get_uid());
responses.push(
CalendarObjectResource::from(event)
CalendarObjectResource::from(object)
.propfind(prefix, &path, props.clone())
.await?,
);
}
for event_uid in deleted_events {
let path = format!("{}/{}", req.path(), event_uid);
for object_uid in deleted_objects {
let path = format!("{}/{}", req.path(), object_uid);
responses.push(ResponseElement {
href: path,
status: Some(format!("HTTP/1.1 {}", StatusCode::NOT_FOUND)),

View File

@@ -11,7 +11,7 @@ CREATE TABLE calendars (
PRIMARY KEY (principal, id)
);
CREATE TABLE events (
CREATE TABLE calendarobjects (
principal TEXT NOT NULL,
cid TEXT NOT NULL,
uid TEXT NOT NULL,
@@ -22,7 +22,7 @@ CREATE TABLE events (
FOREIGN KEY (principal, cid) REFERENCES calendars(principal, id)
);
CREATE TABLE eventchangelog (
CREATE TABLE calendarobjectchangelog (
-- The actual sync token is the SQLite field 'ROWID'
principal TEXT NOT NULL,
cid TEXT NOT NULL,

View File

@@ -1,7 +1,8 @@
pub mod calendar_store;
pub mod error;
pub mod model;
pub mod sqlite_store;
pub mod store;
pub mod timestamp;
pub use calendar_store::CalendarStore;
pub use error::Error;
pub use store::CalendarStore;

View File

@@ -41,7 +41,7 @@ enum CalendarChangeOperation {
}
// Logs an operation to the events
async fn log_event_operation(
async fn log_object_operation(
tx: &mut Transaction<'_, Sqlite>,
principal: &str,
cid: &str,
@@ -61,7 +61,7 @@ async fn log_event_operation(
sqlx::query!(
r#"
INSERT INTO eventchangelog (principal, cid, uid, operation, synctoken)
INSERT INTO calendarobjectchangelog (principal, cid, uid, operation, synctoken)
VALUES (?1, ?2, ?3, ?4, (
SELECT synctoken FROM calendars WHERE (principal, id) = (?1, ?2)
))"#,
@@ -189,7 +189,7 @@ impl CalendarStore for SqliteCalendarStore {
async fn get_objects(&self, principal: &str, cid: &str) -> Result<Vec<CalendarObject>, Error> {
sqlx::query_as!(
CalendarObjectRow,
"SELECT uid, ics FROM events WHERE principal = ? AND cid = ? AND deleted_at IS NULL",
"SELECT uid, ics FROM calendarobjects WHERE principal = ? AND cid = ? AND deleted_at IS NULL",
principal,
cid
)
@@ -206,17 +206,16 @@ impl CalendarStore for SqliteCalendarStore {
cid: &str,
uid: &str,
) -> Result<CalendarObject, Error> {
let event = sqlx::query_as!(
Ok(sqlx::query_as!(
CalendarObjectRow,
"SELECT uid, ics FROM events WHERE (principal, cid, uid) = (?, ?, ?)",
"SELECT uid, ics FROM calendarobjects WHERE (principal, cid, uid) = (?, ?, ?)",
principal,
cid,
uid
)
.fetch_one(&self.db)
.await?
.try_into()?;
Ok(event)
.try_into()?)
}
async fn put_object(
@@ -231,7 +230,7 @@ impl CalendarStore for SqliteCalendarStore {
// input validation
CalendarObject::from_ics(uid.to_owned(), ics.to_owned())?;
sqlx::query!(
"REPLACE INTO events (principal, cid, uid, ics) VALUES (?, ?, ?, ?)",
"REPLACE INTO calendarobjects (principal, cid, uid, ics) VALUES (?, ?, ?, ?)",
principal,
cid,
uid,
@@ -240,7 +239,7 @@ impl CalendarStore for SqliteCalendarStore {
.execute(&mut *tx)
.await?;
log_event_operation(
log_object_operation(
&mut tx,
&principal,
&cid,
@@ -264,7 +263,7 @@ impl CalendarStore for SqliteCalendarStore {
match use_trashbin {
true => {
sqlx::query!(
"UPDATE events SET deleted_at = datetime(), updated_at = datetime() WHERE (principal, cid, uid) = (?, ?, ?)",
"UPDATE calendarobjects SET deleted_at = datetime(), updated_at = datetime() WHERE (principal, cid, uid) = (?, ?, ?)",
principal,
cid,
uid
@@ -273,12 +272,16 @@ impl CalendarStore for SqliteCalendarStore {
.await?;
}
false => {
sqlx::query!("DELETE FROM events WHERE cid = ? AND uid = ?", cid, uid)
.execute(&mut *tx)
.await?;
sqlx::query!(
"DELETE FROM calendarobjects WHERE cid = ? AND uid = ?",
cid,
uid
)
.execute(&mut *tx)
.await?;
}
};
log_event_operation(
log_object_operation(
&mut tx,
principal,
cid,
@@ -294,7 +297,7 @@ impl CalendarStore for SqliteCalendarStore {
let mut tx = self.db.begin().await?;
sqlx::query!(
r#"UPDATE events SET deleted_at = NULL, updated_at = datetime() WHERE (principal, cid, uid) = (?, ?, ?)"#,
r#"UPDATE calendarobjects SET deleted_at = NULL, updated_at = datetime() WHERE (principal, cid, uid) = (?, ?, ?)"#,
principal,
cid,
uid
@@ -302,7 +305,7 @@ impl CalendarStore for SqliteCalendarStore {
.execute(&mut *tx)
.await?;
log_event_operation(
log_object_operation(
&mut tx,
principal,
cid,
@@ -327,7 +330,7 @@ impl CalendarStore for SqliteCalendarStore {
let changes = sqlx::query_as!(
Row,
r#"
SELECT DISTINCT uid, max(0, synctoken) as "synctoken!: i64" from eventchangelog
SELECT DISTINCT uid, max(0, synctoken) as "synctoken!: i64" from calendarobjectchangelog
WHERE synctoken > ?
ORDER BY synctoken ASC
"#,
@@ -336,8 +339,8 @@ impl CalendarStore for SqliteCalendarStore {
.fetch_all(&self.db)
.await?;
let mut events = vec![];
let mut deleted_events = vec![];
let mut objects = vec![];
let mut deleted_objects = vec![];
let new_synctoken = changes
.last()
@@ -346,13 +349,13 @@ impl CalendarStore for SqliteCalendarStore {
for Row { uid, .. } in changes {
match self.get_object(principal, cid, &uid).await {
Ok(event) => events.push(event),
Err(Error::NotFound) => deleted_events.push(uid),
Ok(object) => objects.push(object),
Err(Error::NotFound) => deleted_objects.push(uid),
Err(err) => return Err(err),
}
}
Ok((events, deleted_events, new_synctoken))
Ok((objects, deleted_objects, new_synctoken))
}
}

View File

@@ -1,7 +1,7 @@
use rstest::rstest;
use rstest_reuse::{self, apply, template};
use rustical_store::sqlite_store::create_test_store;
use rustical_store::store::CalendarStore;
use rustical_store::CalendarStore;
const TIMEZONE: &str = include_str!("examples/timezone.ics");
const EVENT: &str = include_str!("examples/event.ics");