xml: Some work on errors

crates/xml/src/de.rs

@@ -67,6 +67,7 @@ impl<T: XmlRootTag + XmlDeserialize> XmlDocument for T {
 
                     return Self::deserialize(&mut reader, &start, empty);
                 }
+                Event::Eof => return Err(XmlError::Eof),
                 _ => return Err(XmlError::UnsupportedEvent("unknown, todo")),
             };
         }

crates/xml/src/error.rs

@@ -4,22 +4,23 @@ use thiserror::Error;
 
 #[derive(Debug, Error)]
 pub enum XmlError {
+    // Syntactix errors
     #[error(transparent)]
     QuickXmlError(#[from] quick_xml::Error),
     #[error(transparent)]
     QuickXmlAttrError(#[from] quick_xml::events::attributes::AttrError),
     #[error(transparent)]
     FromUtf8Error(#[from] FromUtf8Error),
-    #[error("Invalid tag [{0}]{1}. Expected [{2}]{3}")]
-    InvalidTag(String, String, String, String),
-    #[error("Missing field {0}")]
-    MissingField(&'static str),
     #[error("End of file, expected closing tags")]
     Eof,
     #[error("Unsupported xml event: {0}")]
     UnsupportedEvent(&'static str),
-    #[error("{0}")]
-    Other(String),
+
+    // Semantic errors
+    #[error("Invalid tag [{0}]{1}. Expected [{2}]{3}")]
+    InvalidTag(String, String, String, String),
+    #[error("Missing field {0}")]
+    MissingField(&'static str),
     #[error("Invalid variant: {0}")]
     InvalidVariant(String),
     #[error("Invalid field name in {0}: {1}")]

crates/xml/src/value.rs

@@ -22,6 +22,8 @@ pub enum ParseValueError {
     ParseIntError(#[from] ParseIntError),
     #[error(transparent)]
     ParseFloatError(#[from] ParseFloatError),
+    #[error("{0}")]
+    Other(String),
 }
 
 macro_rules! impl_value_parse {