nikdoof/rustical
1
1
Fork 0
mirror of https://github.com/lennart-k/rustical.git synced 2025-12-14 10:32:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

dav proppatch: remove debug and todos

Browse Source
This commit is contained in:
Lennart
2024-10-27 00:43:42 +02:00
parent c4f68e2cf1
commit 42f2ea6ff9
1 changed files with 10 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
crates/dav/src/methods/proppatch.rs
View File

@@ -61,8 +61,6 @@ pub async fn route_proppatch<R: ResourceService>(
let href = req.path().to_owned(); let href = req.path().to_owned();
let resource_service = R::new(&req, path_components.clone()).await?; let resource_service = R::new(&req, path_components.clone()).await?;
debug!("{body}");
let PropertyupdateElement::<<R::Resource as Resource>::Prop> { operations } = let PropertyupdateElement::<<R::Resource as Resource>::Prop> { operations } =
quick_xml::de::from_str(&body).map_err(Error::XmlDecodeError)?; quick_xml::de::from_str(&body).map_err(Error::XmlDecodeError)?;
@@ -102,27 +100,23 @@ pub async fn route_proppatch<R: ResourceService>(
props_conflict.push(propname); props_conflict.push(propname);
} }
Err(err) => { Err(err) => {
// TODO: Think about error handling?
return Err(err.into()); return Err(err.into());
} }
} }
} }
Operation::Remove(_remove_el) => { Operation::Remove(_remove_el) => {
match <<R::Resource as Resource>::PropName as FromStr>::from_str(&propname) { match <<R::Resource as Resource>::PropName as FromStr>::from_str(&propname) {
Ok(prop) => { Ok(prop) => match resource.remove_prop(prop) {
match resource.remove_prop(prop) { Ok(()) => {
Ok(()) => { props_ok.push(propname);
props_ok.push(propname);
}
Err(Error::PropReadOnly) => {
props_conflict.push(propname);
}
Err(err) => {
// TODO: Think about error handling?
return Err(err.into());
}
} }
} Err(Error::PropReadOnly) => {
props_conflict.push(propname);
}
Err(err) => {
return Err(err.into());
}
},
Err(_) => { Err(_) => {
// I guess removing a nonexisting property should be successful :) // I guess removing a nonexisting property should be successful :)
props_ok.push(propname); props_ok.push(propname);