mirror of
https://github.com/elisiariocouto/leggen.git
synced 2025-12-11 17:22:18 +00:00
Split the monolithic DatabaseService (1,492 lines) into focused repository modules using the repository pattern for better maintainability and separation of concerns. Changes: - Create new repositories/ directory with 5 focused repositories: - TransactionRepository: transaction data operations (264 lines) - AccountRepository: account data operations (128 lines) - BalanceRepository: balance data operations (107 lines) - MigrationRepository: all database migrations (629 lines) - SyncRepository: sync operation tracking (132 lines) - BaseRepository: shared database connection logic (28 lines) - Refactor DatabaseService into a clean facade (287 lines): - Delegates data access to repositories - Maintains public API (no breaking changes) - Keeps data processors in service layer - Preserves require_sqlite decorator - Update tests to mock repository methods instead of private methods - Fix test references to internal methods (_persist_*, _get_*) Benefits: - Clear separation of concerns (one repository per domain) - Easier maintenance (changes isolated to specific repositories) - Better testability (repositories can be mocked individually) - Improved code organization (from 1 file to 7 focused files) All 114 tests passing.
172 lines
6.2 KiB
Python
172 lines
6.2 KiB
Python
"""Integration tests for configurable paths."""
|
|
|
|
import os
|
|
import tempfile
|
|
from pathlib import Path
|
|
from unittest.mock import patch
|
|
|
|
import pytest
|
|
|
|
from leggen.services.database_service import DatabaseService
|
|
from leggen.utils.paths import path_manager
|
|
|
|
|
|
@pytest.mark.unit
|
|
class TestConfigurablePaths:
|
|
"""Test configurable path management."""
|
|
|
|
def test_default_paths(self):
|
|
"""Test that default paths are correctly set."""
|
|
# Reset path manager
|
|
original_config = path_manager._config_dir
|
|
original_db = path_manager._database_path
|
|
|
|
try:
|
|
path_manager._config_dir = None
|
|
path_manager._database_path = None
|
|
|
|
# Test defaults
|
|
config_dir = path_manager.get_config_dir()
|
|
db_path = path_manager.get_database_path()
|
|
|
|
assert config_dir == Path.home() / ".config" / "leggen"
|
|
assert db_path == Path.home() / ".config" / "leggen" / "leggen.db"
|
|
finally:
|
|
path_manager._config_dir = original_config
|
|
path_manager._database_path = original_db
|
|
|
|
def test_environment_variables(self):
|
|
"""Test that environment variables override defaults."""
|
|
with tempfile.TemporaryDirectory() as tmpdir:
|
|
test_config_dir = Path(tmpdir) / "test-config"
|
|
test_db_path = Path(tmpdir) / "test.db"
|
|
|
|
with patch.dict(
|
|
os.environ,
|
|
{
|
|
"LEGGEN_CONFIG_DIR": str(test_config_dir),
|
|
"LEGGEN_DATABASE_PATH": str(test_db_path),
|
|
},
|
|
):
|
|
# Reset path manager to pick up environment variables
|
|
original_config = path_manager._config_dir
|
|
original_db = path_manager._database_path
|
|
|
|
try:
|
|
path_manager._config_dir = None
|
|
path_manager._database_path = None
|
|
|
|
config_dir = path_manager.get_config_dir()
|
|
db_path = path_manager.get_database_path()
|
|
|
|
assert config_dir == test_config_dir
|
|
assert db_path == test_db_path
|
|
finally:
|
|
path_manager._config_dir = original_config
|
|
path_manager._database_path = original_db
|
|
|
|
def test_explicit_path_setting(self):
|
|
"""Test explicitly setting paths."""
|
|
with tempfile.TemporaryDirectory() as tmpdir:
|
|
test_config_dir = Path(tmpdir) / "explicit-config"
|
|
test_db_path = Path(tmpdir) / "explicit.db"
|
|
|
|
# Save original paths
|
|
original_config = path_manager._config_dir
|
|
original_db = path_manager._database_path
|
|
|
|
try:
|
|
# Set explicit paths
|
|
path_manager.set_config_dir(test_config_dir)
|
|
path_manager.set_database_path(test_db_path)
|
|
|
|
assert path_manager.get_config_dir() == test_config_dir
|
|
assert path_manager.get_database_path() == test_db_path
|
|
assert (
|
|
path_manager.get_config_file_path()
|
|
== test_config_dir / "config.toml"
|
|
)
|
|
assert (
|
|
path_manager.get_auth_file_path() == test_config_dir / "auth.json"
|
|
)
|
|
finally:
|
|
# Restore original paths
|
|
path_manager._config_dir = original_config
|
|
path_manager._database_path = original_db
|
|
|
|
def test_database_operations_with_custom_path(self):
|
|
"""Test that database operations work with custom paths."""
|
|
with tempfile.NamedTemporaryFile(suffix=".db", delete=False) as tmp_file:
|
|
test_db_path = Path(tmp_file.name)
|
|
|
|
# Save original database path
|
|
original_db = path_manager._database_path
|
|
|
|
try:
|
|
# Set custom database path
|
|
path_manager.set_database_path(test_db_path)
|
|
|
|
# Test database operations using DatabaseService
|
|
database_service = DatabaseService()
|
|
balance_data = {
|
|
"balances": [
|
|
{
|
|
"balanceAmount": {"amount": "1000.0", "currency": "EUR"},
|
|
"balanceType": "available",
|
|
}
|
|
],
|
|
"institution_id": "TEST_BANK",
|
|
"account_status": "active",
|
|
"iban": "TEST_IBAN",
|
|
}
|
|
|
|
# Use the public balance persistence method
|
|
import asyncio
|
|
|
|
asyncio.run(database_service.persist_balance("test-account", balance_data))
|
|
|
|
# Retrieve balances
|
|
balances = asyncio.run(
|
|
database_service.get_balances_from_db("test-account")
|
|
)
|
|
|
|
assert len(balances) == 1
|
|
assert balances[0]["account_id"] == "test-account"
|
|
assert balances[0]["amount"] == 1000.0
|
|
|
|
# Verify database file exists at custom location
|
|
assert test_db_path.exists()
|
|
|
|
finally:
|
|
# Restore original path and cleanup
|
|
path_manager._database_path = original_db
|
|
if test_db_path.exists():
|
|
test_db_path.unlink()
|
|
|
|
def test_directory_creation(self):
|
|
"""Test that directories are created as needed."""
|
|
with tempfile.TemporaryDirectory() as tmpdir:
|
|
test_config_dir = Path(tmpdir) / "new" / "config" / "dir"
|
|
test_db_path = Path(tmpdir) / "new" / "db" / "dir" / "test.db"
|
|
|
|
# Save original paths
|
|
original_config = path_manager._config_dir
|
|
original_db = path_manager._database_path
|
|
|
|
try:
|
|
# Set paths to non-existent directories
|
|
path_manager.set_config_dir(test_config_dir)
|
|
path_manager.set_database_path(test_db_path)
|
|
|
|
# Ensure directories are created
|
|
path_manager.ensure_config_dir_exists()
|
|
path_manager.ensure_database_dir_exists()
|
|
|
|
assert test_config_dir.exists()
|
|
assert test_db_path.parent.exists()
|
|
|
|
finally:
|
|
# Restore original paths
|
|
path_manager._config_dir = original_config
|
|
path_manager._database_path = original_db
|