feat: Add mypy to pre-commit.

leggend/api/models/common.py

@@ -1,4 +1,3 @@
-from datetime import datetime
 from typing import Any, Dict, Optional
 
 from pydantic import BaseModel

leggend/api/models/notifications.py

@@ -1,4 +1,4 @@
-from typing import Dict, Any, Optional, List
+from typing import Dict, Optional, List
 
 from pydantic import BaseModel
 

leggend/api/models/sync.py

@@ -1,5 +1,5 @@
 from datetime import datetime
-from typing import Optional, Dict, Any
+from typing import Optional
 
 from pydantic import BaseModel
 

leggend/api/routes/accounts.py

@@ -1,4 +1,4 @@
-from typing import List, Optional
+from typing import Optional, List, Union
 from fastapi import APIRouter, HTTPException, Query
 from loguru import logger
 
@@ -74,7 +74,9 @@ async def get_all_accounts() -> APIResponse:
 
     except Exception as e:
         logger.error(f"Failed to get accounts: {e}")
-        raise HTTPException(status_code=500, detail=f"Failed to get accounts: {str(e)}")
+        raise HTTPException(
+            status_code=500, detail=f"Failed to get accounts: {str(e)}"
+        ) from e
 
 
 @router.get("/accounts/{account_id}", response_model=APIResponse)
@@ -117,7 +119,9 @@ async def get_account_details(account_id: str) -> APIResponse:
 
     except Exception as e:
         logger.error(f"Failed to get account details for {account_id}: {e}")
-        raise HTTPException(status_code=404, detail=f"Account not found: {str(e)}")
+        raise HTTPException(
+            status_code=404, detail=f"Account not found: {str(e)}"
+        ) from e
 
 
 @router.get("/accounts/{account_id}/balances", response_model=APIResponse)
@@ -146,7 +150,9 @@ async def get_account_balances(account_id: str) -> APIResponse:
 
     except Exception as e:
         logger.error(f"Failed to get balances for account {account_id}: {e}")
-        raise HTTPException(status_code=404, detail=f"Failed to get balances: {str(e)}")
+        raise HTTPException(
+            status_code=404, detail=f"Failed to get balances: {str(e)}"
+        ) from e
 
 
 @router.get("/accounts/{account_id}/transactions", response_model=APIResponse)
@@ -172,11 +178,17 @@ async def get_account_transactions(
 
         # Apply pagination
         total_transactions = len(processed_transactions)
-        paginated_transactions = processed_transactions[offset : offset + limit]
+        actual_offset = offset or 0
+        actual_limit = limit or 100
+        paginated_transactions = processed_transactions[
+            actual_offset : actual_offset + actual_limit
+        ]
+
+        data: Union[List[TransactionSummary], List[Transaction]]
 
         if summary_only:
             # Return simplified transaction summaries
-            summaries = [
+            data = [
                 TransactionSummary(
                     internal_transaction_id=txn["internalTransactionId"],
                     date=txn["transactionDate"],
@@ -188,10 +200,9 @@ async def get_account_transactions(
                 )
                 for txn in paginated_transactions
             ]
-            data = summaries
         else:
             # Return full transaction details
-            transactions = [
+            data = [
                 Transaction(
                     internal_transaction_id=txn["internalTransactionId"],
                     institution_id=txn["institutionId"],
@@ -206,16 +217,15 @@ async def get_account_transactions(
                 )
                 for txn in paginated_transactions
             ]
-            data = transactions
 
         return APIResponse(
             success=True,
             data=data,
-            message=f"Retrieved {len(data)} transactions (showing {offset + 1}-{offset + len(data)} of {total_transactions})",
+            message=f"Retrieved {len(data)} transactions (showing {actual_offset + 1}-{actual_offset + len(data)} of {total_transactions})",
         )
 
     except Exception as e:
         logger.error(f"Failed to get transactions for account {account_id}: {e}")
         raise HTTPException(
             status_code=404, detail=f"Failed to get transactions: {str(e)}"
-        )
+        ) from e

leggend/api/routes/banks.py

@@ -1,8 +1,7 @@
-from typing import List, Optional
 from fastapi import APIRouter, HTTPException, Query
 from loguru import logger
 
-from leggend.api.models.common import APIResponse, ErrorResponse
+from leggend.api.models.common import APIResponse
 from leggend.api.models.banks import (
     BankInstitution,
     BankConnectionRequest,
@@ -46,15 +45,16 @@ async def get_bank_institutions(
         logger.error(f"Failed to get institutions for {country}: {e}")
         raise HTTPException(
             status_code=500, detail=f"Failed to get institutions: {str(e)}"
-        )
+        ) from e
 
 
 @router.post("/banks/connect", response_model=APIResponse)
 async def connect_to_bank(request: BankConnectionRequest) -> APIResponse:
     """Create a connection to a bank (requisition)"""
     try:
+        redirect_url = request.redirect_url or "http://localhost:8000/"
         requisition_data = await gocardless_service.create_requisition(
-            request.institution_id, request.redirect_url
+            request.institution_id, redirect_url
         )
 
         requisition = BankRequisition(
@@ -69,14 +69,14 @@ async def connect_to_bank(request: BankConnectionRequest) -> APIResponse:
         return APIResponse(
             success=True,
             data=requisition,
-            message=f"Bank connection created. Please visit the link to authorize.",
+            message="Bank connection created. Please visit the link to authorize.",
         )
 
     except Exception as e:
         logger.error(f"Failed to connect to bank {request.institution_id}: {e}")
         raise HTTPException(
             status_code=500, detail=f"Failed to connect to bank: {str(e)}"
-        )
+        ) from e
 
 
 @router.get("/banks/status", response_model=APIResponse)
@@ -114,7 +114,7 @@ async def get_bank_connections_status() -> APIResponse:
         logger.error(f"Failed to get bank connection status: {e}")
         raise HTTPException(
             status_code=500, detail=f"Failed to get bank status: {str(e)}"
-        )
+        ) from e
 
 
 @router.delete("/banks/connections/{requisition_id}", response_model=APIResponse)
@@ -132,7 +132,7 @@ async def delete_bank_connection(requisition_id: str) -> APIResponse:
         logger.error(f"Failed to delete bank connection {requisition_id}: {e}")
         raise HTTPException(
             status_code=500, detail=f"Failed to delete connection: {str(e)}"
-        )
+        ) from e
 
 
 @router.get("/banks/countries", response_model=APIResponse)

leggend/api/routes/notifications.py

@@ -1,4 +1,4 @@
-from typing import Optional
+from typing import Dict, Any
 from fastapi import APIRouter, HTTPException
 from loguru import logger
 
@@ -60,7 +60,7 @@ async def get_notification_settings() -> APIResponse:
         logger.error(f"Failed to get notification settings: {e}")
         raise HTTPException(
             status_code=500, detail=f"Failed to get notification settings: {str(e)}"
-        )
+        ) from e
 
 
 @router.put("/notifications/settings", response_model=APIResponse)
@@ -84,7 +84,7 @@ async def update_notification_settings(settings: NotificationSettings) -> APIRes
             }
 
         # Update filters config
-        filters_config = {}
+        filters_config: Dict[str, Any] = {}
         if settings.filters.case_insensitive:
             filters_config["case-insensitive"] = settings.filters.case_insensitive
         if settings.filters.case_sensitive:
@@ -110,7 +110,7 @@ async def update_notification_settings(settings: NotificationSettings) -> APIRes
         logger.error(f"Failed to update notification settings: {e}")
         raise HTTPException(
             status_code=500, detail=f"Failed to update notification settings: {str(e)}"
-        )
+        ) from e
 
 
 @router.post("/notifications/test", response_model=APIResponse)
@@ -137,7 +137,7 @@ async def test_notification(test_request: NotificationTest) -> APIResponse:
         logger.error(f"Failed to send test notification: {e}")
         raise HTTPException(
             status_code=500, detail=f"Failed to send test notification: {str(e)}"
-        )
+        ) from e
 
 
 @router.get("/notifications/services", response_model=APIResponse)
@@ -179,7 +179,7 @@ async def get_notification_services() -> APIResponse:
         logger.error(f"Failed to get notification services: {e}")
         raise HTTPException(
             status_code=500, detail=f"Failed to get notification services: {str(e)}"
-        )
+        ) from e
 
 
 @router.delete("/notifications/settings/{service}", response_model=APIResponse)
@@ -206,4 +206,4 @@ async def delete_notification_service(service: str) -> APIResponse:
         logger.error(f"Failed to delete notification service {service}: {e}")
         raise HTTPException(
             status_code=500, detail=f"Failed to delete notification service: {str(e)}"
-        )
+        ) from e

leggend/api/routes/sync.py

@@ -3,7 +3,7 @@ from fastapi import APIRouter, HTTPException, BackgroundTasks
 from loguru import logger
 
 from leggend.api.models.common import APIResponse
-from leggend.api.models.sync import SyncRequest, SyncStatus, SyncResult, SchedulerConfig
+from leggend.api.models.sync import SyncRequest, SchedulerConfig
 from leggend.services.sync_service import SyncService
 from leggend.background.scheduler import scheduler
 from leggend.config import config
@@ -31,7 +31,7 @@ async def get_sync_status() -> APIResponse:
         logger.error(f"Failed to get sync status: {e}")
         raise HTTPException(
             status_code=500, detail=f"Failed to get sync status: {str(e)}"
-        )
+        ) from e
 
 
 @router.post("/sync", response_model=APIResponse)
@@ -78,7 +78,9 @@ async def trigger_sync(
 
     except Exception as e:
         logger.error(f"Failed to trigger sync: {e}")
-        raise HTTPException(status_code=500, detail=f"Failed to trigger sync: {str(e)}")
+        raise HTTPException(
+            status_code=500, detail=f"Failed to trigger sync: {str(e)}"
+        ) from e
 
 
 @router.post("/sync/now", response_model=APIResponse)
@@ -104,7 +106,9 @@ async def sync_now(sync_request: Optional[SyncRequest] = None) -> APIResponse:
 
     except Exception as e:
         logger.error(f"Failed to run sync: {e}")
-        raise HTTPException(status_code=500, detail=f"Failed to run sync: {str(e)}")
+        raise HTTPException(
+            status_code=500, detail=f"Failed to run sync: {str(e)}"
+        ) from e
 
 
 @router.get("/sync/scheduler", response_model=APIResponse)
@@ -134,7 +138,7 @@ async def get_scheduler_config() -> APIResponse:
         logger.error(f"Failed to get scheduler config: {e}")
         raise HTTPException(
             status_code=500, detail=f"Failed to get scheduler config: {str(e)}"
-        )
+        ) from e
 
 
 @router.put("/sync/scheduler", response_model=APIResponse)
@@ -152,7 +156,7 @@ async def update_scheduler_config(scheduler_config: SchedulerConfig) -> APIRespo
             except Exception as e:
                 raise HTTPException(
                     status_code=400, detail=f"Invalid cron expression: {str(e)}"
-                )
+                ) from e
 
         # Update configuration
         schedule_data = scheduler_config.dict(exclude_none=True)
@@ -171,7 +175,7 @@ async def update_scheduler_config(scheduler_config: SchedulerConfig) -> APIRespo
         logger.error(f"Failed to update scheduler config: {e}")
         raise HTTPException(
             status_code=500, detail=f"Failed to update scheduler config: {str(e)}"
-        )
+        ) from e
 
 
 @router.post("/sync/scheduler/start", response_model=APIResponse)
@@ -188,7 +192,7 @@ async def start_scheduler() -> APIResponse:
         logger.error(f"Failed to start scheduler: {e}")
         raise HTTPException(
             status_code=500, detail=f"Failed to start scheduler: {str(e)}"
-        )
+        ) from e
 
 
 @router.post("/sync/scheduler/stop", response_model=APIResponse)
@@ -205,4 +209,4 @@ async def stop_scheduler() -> APIResponse:
         logger.error(f"Failed to stop scheduler: {e}")
         raise HTTPException(
             status_code=500, detail=f"Failed to stop scheduler: {str(e)}"
-        )
+        ) from e

leggend/api/routes/transactions.py

@@ -1,4 +1,4 @@
-from typing import List, Optional
+from typing import Optional, List, Union
 from datetime import datetime, timedelta
 from fastapi import APIRouter, HTTPException, Query
 from loguru import logger
@@ -120,7 +120,13 @@ async def get_all_transactions(
 
         # Apply pagination
         total_transactions = len(filtered_transactions)
-        paginated_transactions = filtered_transactions[offset : offset + limit]
+        actual_offset = offset or 0
+        actual_limit = limit or 100
+        paginated_transactions = filtered_transactions[
+            actual_offset : actual_offset + actual_limit
+        ]
+
+        data: Union[List[TransactionSummary], List[Transaction]]
 
         if summary_only:
             # Return simplified transaction summaries
@@ -157,14 +163,14 @@ async def get_all_transactions(
         return APIResponse(
             success=True,
             data=data,
-            message=f"Retrieved {len(data)} transactions (showing {offset + 1}-{offset + len(data)} of {total_transactions})",
+            message=f"Retrieved {len(data)} transactions (showing {actual_offset + 1}-{actual_offset + len(data)} of {total_transactions})",
         )
 
     except Exception as e:
         logger.error(f"Failed to get transactions: {e}")
         raise HTTPException(
             status_code=500, detail=f"Failed to get transactions: {str(e)}"
-        )
+        ) from e
 
 
 @router.get("/transactions/stats", response_model=APIResponse)
@@ -270,4 +276,4 @@ async def get_transaction_stats(
         logger.error(f"Failed to get transaction stats: {e}")
         raise HTTPException(
             status_code=500, detail=f"Failed to get transaction stats: {str(e)}"
-        )
+        ) from e