refactor: remove unused hide_missing_ids functionality

- Remove hide_missing_ids parameter from all database functions
- Remove hide_missing_ids from API routes and query parameters
- Remove hide_missing_ids filtering logic from SQLite queries
- Update all tests to remove hide_missing_ids assertions
- Clean up codebase since internalTransactionId extraction is now fixed

This functionality was added as a workaround for missing internalTransactionId
values, but we've now fixed the root cause by properly extracting transaction
IDs from raw data during sync, making this workaround unnecessary.

leggen/database/sqlite.py

@@ -210,7 +210,6 @@ def get_transactions(
     min_amount=None,
     max_amount=None,
     search=None,
-    hide_missing_ids=True,
 ):
     """Get transactions from SQLite database with optional filtering"""
     from pathlib import Path
@@ -250,11 +249,6 @@ def get_transactions(
         query += " AND description LIKE ?"
         params.append(f"%{search}%")
 
-    if hide_missing_ids:
-        query += (
-            " AND internalTransactionId IS NOT NULL AND internalTransactionId != ''"
-        )
-
     # Add ordering and pagination
     query += " ORDER BY transactionDate DESC"
 
@@ -403,11 +397,6 @@ def get_transaction_count(account_id=None, **filters):
         query += " AND description LIKE ?"
         params.append(f"%{filters['search']}%")
 
-    if filters.get("hide_missing_ids", True):
-        query += (
-            " AND internalTransactionId IS NOT NULL AND internalTransactionId != ''"
-        )
-
     try:
         cursor.execute(query, params)
         count = cursor.fetchone()[0]

leggen/utils/database.py

@@ -69,8 +69,13 @@ def save_transactions(ctx: click.Context, account: str) -> list:
             ",".join(transaction.get("remittanceInformationUnstructuredArray", [])),
         )
 
+        # Extract transaction ID, using transactionId as fallback when internalTransactionId is missing
+        transaction_id = transaction.get("internalTransactionId") or transaction.get(
+            "transactionId"
+        )
+
         t = {
-            "internalTransactionId": transaction.get("internalTransactionId"),
+            "internalTransactionId": transaction_id,
             "institutionId": account_info["institution_id"],
             "iban": account_info.get("iban", "N/A"),
             "transactionDate": min_date,
@@ -105,8 +110,13 @@ def save_transactions(ctx: click.Context, account: str) -> list:
             ",".join(transaction.get("remittanceInformationUnstructuredArray", [])),
         )
 
+        # Extract transaction ID, using transactionId as fallback when internalTransactionId is missing
+        transaction_id = transaction.get("internalTransactionId") or transaction.get(
+            "transactionId"
+        )
+
         t = {
-            "internalTransactionId": transaction.get("internalTransactionId"),
+            "internalTransactionId": transaction_id,
             "institutionId": account_info["institution_id"],
             "iban": account_info.get("iban", "N/A"),
             "transactionDate": min_date,