From 40302d6ec0b2d4dec5143a8fd7c2886f11ee4bb3 Mon Sep 17 00:00:00 2001
From: Darell Tan <darell.tan@gmail.com>
Date: Sun, 24 Nov 2024 16:13:24 +0800
Subject: [PATCH] Code cleanup

---
 bridge.go | 37 ++++++++++++++++++++++++++-----------
 1 file changed, 26 insertions(+), 11 deletions(-)

diff --git a/bridge.go b/bridge.go
index c4786b6..f9c5c36 100644
--- a/bridge.go
+++ b/bridge.go
@@ -624,6 +624,27 @@ func (br *Bridge) PublishState(dev *Device, payload map[string]any) error {
 	return nil
 }
 
+func parseLastSeen(ts any) (time.Time, error) {
+	var lastSeen time.Time
+	var err error
+
+	switch v := ts.(type) {
+	case float64:
+		lastSeen = time.Unix(int64(v/1000), 0)
+
+	case string:
+		if lastSeenDate, err := time.Parse(time.RFC3339, v); err == nil {
+			lastSeen = lastSeenDate
+		} else {
+			err = fmt.Errorf("invalid last_seen timestamp %v", v)
+		}
+
+	default:
+		err = fmt.Errorf("invalid last_seen %T %[1]v", v)
+	}
+	return lastSeen, err
+}
+
 // Handle MQTT message to update accessory state
 func (br *Bridge) UpdateAccessoryState(devName string, payload []byte) {
 	dev := br.devices[devName]
@@ -649,17 +670,11 @@ func (br *Bridge) UpdateAccessoryState(devName string, payload []byte) {
 
 	lastSeen := time.Now()
 	if lastSeenProp, found := newState["last_seen"]; found {
-		switch v := lastSeenProp.(type) {
-		case float64:
-			lastSeen = time.Unix(int64(v/1000), 0)
-		case string:
-			if lastSeenDate, err := time.Parse(time.RFC3339, v); err == nil {
-				lastSeen = lastSeenDate
-			} else {
-				log.Printf("invalid last_seen timestamp %v", v)
-			}
-		default:
-			log.Printf("invalid last_seen %T %[1]v", v)
+		ts, err := parseLastSeen(lastSeenProp)
+		if err == nil {
+			lastSeen = ts
+		} else {
+			log.Println(err)
 		}
 	}