nikdoof/MacPass
1
1
Fork 0
mirror of https://github.com/MacPass/MacPass.git synced 2025-12-14 09:22:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

masked value should not be cached since it might include references

Browse Source
This commit is contained in:
michael starke
2017-11-08 13:23:06 +01:00
parent c8bc829600
commit b20631da6e
1 changed files with 4 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
MacPass/MPAutotypeContext.m
View File

@@ -26,7 +26,6 @@
@interface MPAutotypeContext () { @interface MPAutotypeContext () {
NSString *_evaluatedCommand; NSString *_evaluatedCommand;
NSString *_maskedEvaluatedCommand;
} }
@end @end
@@ -71,13 +70,10 @@
} }
- (NSString *)maskedEvaluatedCommand { - (NSString *)maskedEvaluatedCommand {
if(!_maskedEvaluatedCommand) { NSString *passwordPlaceholder = [NSString stringWithFormat:@"{%@}",kKPKPasswordKey];
NSString *passwordPlaceholder = [NSString stringWithFormat:@"{%@}",kKPKPasswordKey]; NSString *normalized = self.normalizedCommand;
NSString *normalized = self.normalizedCommand; NSString *masked = [normalized stringByReplacingOccurrencesOfString:passwordPlaceholder withString:@"•••" options:NSCaseInsensitiveSearch range:NSMakeRange(0, normalized.length)];
NSString *masked = [normalized stringByReplacingOccurrencesOfString:passwordPlaceholder withString:@"•••••" options:NSCaseInsensitiveSearch range:NSMakeRange(0, normalized.length)]; return [[masked kpk_finalValueForEntry:self.entry] copy];
_maskedEvaluatedCommand = [[masked kpk_finalValueForEntry:self.entry] copy];
}
return _maskedEvaluatedCommand;
} }
- (NSString *)description { - (NSString *)description {