nikdoof/MacPass
1
1
Fork 0
mirror of https://github.com/MacPass/MacPass.git synced 2025-12-23 13:49:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

implemented delegation from menu actions to plugins

Browse Source
This commit is contained in:
Michael Starke
2018-02-15 18:48:02 +01:00
parent f759e6788c
commit 8b60ae4242
4 changed files with 91 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

45
MacPass/MPPluginHost.m
View File

@@ -25,6 +25,8 @@
#import "MPPlugin.h"
#import "MPPlugin_Private.h"
#import "MPPluginConstants.h"
#import "MPPluginEntryActionContext.h"
#import "NSApplication+MPAdditions.h"
#import "MPSettingsHelper.h"
@@ -40,8 +42,8 @@ NSString *const MPPluginHostPluginBundleIdentifiyerKey = @"MPPluginHostPluginBun
@interface MPPluginHost ()
@property (strong) NSMutableArray<MPPlugin __kindof *> *mutablePlugins;
@property (strong) NSPointerArray *entryActionPlugins;
@property (strong) NSPointerArray *customAttributePlugins;
@property (strong) NSMutableArray<NSString *> *entryActionPluginIdentifiers;
@property (strong) NSMutableArray<NSString *> *customAttributePluginIdentifiers;
@property (nonatomic) BOOL loadUnsecurePlugins;
@@ -74,8 +76,8 @@ NSString *const MPPluginHostPluginBundleIdentifiyerKey = @"MPPluginHostPluginBun
_mutablePlugins = [[NSMutableArray alloc] init];
_disabledPlugins = [[NSUserDefaults standardUserDefaults] arrayForKey:kMPSettingsKeyLoadUnsecurePlugins];
_loadUnsecurePlugins = [[NSUserDefaults standardUserDefaults] boolForKey:kMPSettingsKeyLoadUnsecurePlugins];
_entryActionPlugins = [NSPointerArray weakObjectsPointerArray];
_customAttributePlugins = [NSPointerArray weakObjectsPointerArray];
_entryActionPluginIdentifiers = [[NSMutableArray alloc] init];
_customAttributePluginIdentifiers = [[NSMutableArray alloc] init];
[self _loadPlugins];
@@ -296,25 +298,52 @@ NSString *const MPPluginHostPluginBundleIdentifiyerKey = @"MPPluginHostPluginBun
- (void)_addPlugin:(MPPlugin *)plugin {
[self.mutablePlugins addObject:plugin];
if([plugin conformsToProtocol:@protocol(MPEntryActionPlugin)]) {
[self.entryActionPlugins addPointer:(__bridge void * _Nullable)(plugin)];
NSAssert(![self.entryActionPluginIdentifiers containsObject:plugin.identifier], @"Internal inconsitency. Duplicate bundle identifier used %@!", plugin.identifier);
[self.entryActionPluginIdentifiers addObject:plugin.identifier];
}
if([plugin conformsToProtocol:@protocol(MPCustomAttributePlugin)]) {
[self.customAttributePlugins addPointer:(__bridge void * _Nullable)(plugin)];
NSAssert(![self.customAttributePluginIdentifiers containsObject:plugin.identifier], @"Internal inconsitency. Duplicate bundle identifier used %@!", plugin.identifier);
[self.customAttributePluginIdentifiers addObject:plugin.identifier];
}
}
- (MPPlugin *)_pluginWithIdentifier:(NSString *)bundleIdentifier {
for(MPPlugin *plugin in self.mutablePlugins) {
if([plugin.identifier isEqualToString:bundleIdentifier]) {
return plugin;
}
}
return nil;
}
#pragma mark Action Plugins
- (NSArray *)avilableMenuItemsForEntries:(NSArray<KPKEntry *> *)entries {
NSMutableArray *items = [[NSMutableArray alloc] init];
for(id<MPEntryActionPlugin> plugin in self.entryActionPlugins) {
for(NSString *identifier in self.entryActionPluginIdentifiers) {
MPPlugin<MPEntryActionPlugin> *plugin = (MPPlugin<MPEntryActionPlugin> *)[self _pluginWithIdentifier:identifier];
if(plugin) {
[items addObjectsFromArray:[plugin menuItemsForEntries:entries]];
NSArray <NSMenuItem *> *tmpItems = [plugin menuItemsForEntries:entries];
for(NSMenuItem *item in tmpItems) {
item.representedObject = [[MPPluginEntryActionContext alloc] initWithPlugin:plugin entries:entries];
item.target = self;
item.action = @selector(_performEntryAction:);
}
[items addObjectsFromArray:tmpItems];
}
}
return [items copy];
}
- (void)_performEntryAction:(id)sender {
if(![sender isKindOfClass:NSMenuItem.class]) {
return;
}
NSMenuItem *item = sender;
MPPluginEntryActionContext *context = item.representedObject;
[context.plugin performActionForMenuItem:item withEntries:context.entries];
}
@end