diff --git a/MacPass/Base.lproj/PluginSettings.xib b/MacPass/Base.lproj/PluginSettings.xib index 70e3f705..b4cc97e3 100644 --- a/MacPass/Base.lproj/PluginSettings.xib +++ b/MacPass/Base.lproj/PluginSettings.xib @@ -1,9 +1,9 @@ - - + + - - + + @@ -19,14 +19,12 @@ - + - - - + @@ -51,7 +49,7 @@ - + @@ -74,8 +72,9 @@ - + + @@ -92,7 +91,6 @@ - @@ -122,7 +120,7 @@ - + diff --git a/MacPass/MPEntryInspectorViewController.m b/MacPass/MPEntryInspectorViewController.m index 3c5bc22e..1fb5417f 100644 --- a/MacPass/MPEntryInspectorViewController.m +++ b/MacPass/MPEntryInspectorViewController.m @@ -386,7 +386,7 @@ typedef NS_ENUM(NSUInteger, MPEntryTab) { [self.expiresCheckButton bind:NSTitleBinding toObject:self withKeyPath:[NSString stringWithFormat:@"%@.%@.%@", NSStringFromSelector(@selector(representedObject)), NSStringFromSelector(@selector(timeInfo)), NSStringFromSelector(@selector(expirationDate))] - options:@{ NSValueTransformerNameBindingOption:MPExpiryDateValueTransformer }]; + options:@{ NSValueTransformerNameBindingOption:MPExpiryDateValueTransformerName }]; [self.expiresCheckButton bind:NSValueBinding toObject:self withKeyPath:[NSString stringWithFormat:@"%@.%@.%@", NSStringFromSelector(@selector(representedObject)), NSStringFromSelector(@selector(timeInfo)), NSStringFromSelector(@selector(expires))] diff --git a/MacPass/MPGroupInspectorViewController.m b/MacPass/MPGroupInspectorViewController.m index 2416b9a7..d57f94d9 100644 --- a/MacPass/MPGroupInspectorViewController.m +++ b/MacPass/MPGroupInspectorViewController.m @@ -84,7 +84,7 @@ [self.expiresCheckButton bind:NSTitleBinding toObject:self withKeyPath:[NSString stringWithFormat:@"%@.%@.%@", NSStringFromSelector(@selector(representedObject)), NSStringFromSelector(@selector(timeInfo)), NSStringFromSelector(@selector(expirationDate))] - options:@{ NSValueTransformerNameBindingOption:MPExpiryDateValueTransformer }]; + options:@{ NSValueTransformerNameBindingOption:MPExpiryDateValueTransformerName }]; [self.autotypePopupButton bind:NSSelectedTagBinding toObject:self withKeyPath:[NSString stringWithFormat:@"%@.%@", NSStringFromSelector(@selector(representedObject)), NSStringFromSelector(@selector(isAutoTypeEnabled))] diff --git a/MacPass/MPValueTransformerHelper.h b/MacPass/MPValueTransformerHelper.h index cc73b679..3b3fd3b2 100644 --- a/MacPass/MPValueTransformerHelper.h +++ b/MacPass/MPValueTransformerHelper.h @@ -9,7 +9,7 @@ #import FOUNDATION_EXPORT NSString *const MPStripLineBreaksTransformerName; -FOUNDATION_EXPORT NSString *const MPExpiryDateValueTransformer; +FOUNDATION_EXPORT NSString *const MPExpiryDateValueTransformerName; @interface MPValueTransformerHelper : NSObject diff --git a/MacPass/MPValueTransformerHelper.m b/MacPass/MPValueTransformerHelper.m index 7d56269f..db982b63 100644 --- a/MacPass/MPValueTransformerHelper.m +++ b/MacPass/MPValueTransformerHelper.m @@ -10,33 +10,33 @@ #import "NSValueTransformer+TransformerKit.h" NSString *const MPStripLineBreaksTransformerName = @"com.hicknhack.macpass.MPStripLineBreaksTransformerName"; -NSString *const MPExpiryDateValueTransformer = @"com.hicknhack.macpass.kMPExpiryDateValueTransformer"; +NSString *const MPExpiryDateValueTransformerName = @"com.hicknhack.macpass.MPExpiryDateValueTransformer"; @implementation MPValueTransformerHelper + (void)registerValueTransformer { [NSValueTransformer registerValueTransformerWithName:MPStripLineBreaksTransformerName - transformedValueClass:[NSString class] + transformedValueClass:NSString.class returningTransformedValueWithBlock:^id(id value) { - if(![value isKindOfClass:[NSString class]]) { + if(![value isKindOfClass:NSString.class]) { return @""; } - NSArray *elements = [value componentsSeparatedByCharactersInSet:[NSCharacterSet newlineCharacterSet]]; + NSArray *elements = [value componentsSeparatedByCharactersInSet:NSCharacterSet.newlineCharacterSet]; return [elements componentsJoinedByString:@" "]; }]; - [NSValueTransformer registerValueTransformerWithName:MPExpiryDateValueTransformer - transformedValueClass:[NSString class] + [NSValueTransformer registerValueTransformerWithName:MPExpiryDateValueTransformerName + transformedValueClass:NSString.class returningTransformedValueWithBlock:^id(id value) { - if(![value isKindOfClass:[NSDate class]]) { + if(![value isKindOfClass:NSDate.class]) { return NSLocalizedString(@"NO_EXPIRE_DATE_SET",""); } static NSDateFormatter *formatter; if(!formatter) { formatter = [[NSDateFormatter alloc] init]; - [formatter setDateStyle:NSDateFormatterFullStyle]; - [formatter setTimeStyle:NSDateFormatterNoStyle]; + formatter.dateStyle = NSDateFormatterFullStyle; + formatter.timeStyle = NSDateFormatterNoStyle; } NSString *template = NSLocalizedString(@"EXPIRES_AT_DATE_%@", ""); return [[NSString alloc] initWithFormat:template, [formatter stringFromDate:value]];