From 6a28d0380105d9fe2cb1e95c293f78f6d7e28cee Mon Sep 17 00:00:00 2001
From: michael starke <michael.starke@hicknhack-software.com>
Date: Tue, 18 Mar 2014 19:32:52 +0100
Subject: [PATCH] Fixed #159 URL is now below Password Sorting columns is added
 (as mentioned in #64)

---
 MacPass/EntryInspectorView.xib       |  23 +++++++++++++----------
 MacPass/EntryView.xib                |   2 +-
 MacPass/GroupInspectorView.xib       |  20 ++++++++++----------
 MacPass/MPEntryViewController.m      |   2 +-
 MacPass/MPToolbarDelegate.m          |   4 ++--
 MacPass/de.lproj/Localizable.strings | Bin 8996 -> 9612 bytes
 MacPass/en.lproj/Localizable.strings | Bin 8824 -> 9030 bytes
 MacPass/fr.lproj/Localizable.strings | Bin 9170 -> 9748 bytes
 8 files changed, 27 insertions(+), 24 deletions(-)

diff --git a/MacPass/EntryInspectorView.xib b/MacPass/EntryInspectorView.xib
index cbe8bb09..bd1671dc 100644
--- a/MacPass/EntryInspectorView.xib
+++ b/MacPass/EntryInspectorView.xib
@@ -514,7 +514,7 @@ CA
                     </connections>
                 </textField>
                 <textField verticalHuggingPriority="750" translatesAutoresizingMaskIntoConstraints="NO" id="56" customClass="HNHRoundedTextField">
-                    <rect key="frame" x="20" y="237" width="212" height="22"/>
+                    <rect key="frame" x="20" y="157" width="212" height="22"/>
                     <autoresizingMask key="autoresizingMask" flexibleMaxX="YES" flexibleMinY="YES"/>
                     <textFieldCell key="cell" lineBreakMode="truncatingTail" truncatesLastVisibleLine="YES" selectable="YES" editable="YES" sendsActionOnEndEditing="YES" state="on" borderStyle="bezel" drawsBackground="YES" usesSingleLineMode="YES" id="67">
                         <font key="font" metaFont="system"/>
@@ -526,7 +526,7 @@ CA
                     </connections>
                 </textField>
                 <textField verticalHuggingPriority="750" translatesAutoresizingMaskIntoConstraints="NO" id="57">
-                    <rect key="frame" x="18" y="267" width="25" height="14"/>
+                    <rect key="frame" x="18" y="187" width="25" height="14"/>
                     <autoresizingMask key="autoresizingMask" flexibleMaxX="YES" flexibleMinY="YES"/>
                     <textFieldCell key="cell" controlSize="small" scrollable="YES" lineBreakMode="clipping" sendsActionOnEndEditing="YES" title="URL" id="66">
                         <font key="font" metaFont="smallSystem"/>
@@ -535,7 +535,7 @@ CA
                     </textFieldCell>
                 </textField>
                 <textField verticalHuggingPriority="750" translatesAutoresizingMaskIntoConstraints="NO" id="58">
-                    <rect key="frame" x="18" y="211" width="57" height="14"/>
+                    <rect key="frame" x="18" y="267" width="57" height="14"/>
                     <autoresizingMask key="autoresizingMask" flexibleMaxX="YES" flexibleMinY="YES"/>
                     <textFieldCell key="cell" controlSize="small" scrollable="YES" lineBreakMode="clipping" sendsActionOnEndEditing="YES" title="Password" id="65">
                         <font key="font" metaFont="smallSystem"/>
@@ -544,7 +544,7 @@ CA
                     </textFieldCell>
                 </textField>
                 <button verticalHuggingPriority="750" translatesAutoresizingMaskIntoConstraints="NO" id="59">
-                    <rect key="frame" x="20" y="152" width="212" height="19"/>
+                    <rect key="frame" x="20" y="208" width="212" height="19"/>
                     <autoresizingMask key="autoresizingMask" flexibleMaxX="YES" flexibleMinY="YES"/>
                     <buttonCell key="cell" type="roundRect" title="Generate" bezelStyle="roundedRect" alignment="center" state="on" borderStyle="border" imageScaling="proportionallyDown" inset="2" id="64">
                         <behavior key="behavior" pushIn="YES" lightByBackground="YES" lightByGray="YES"/>
@@ -555,7 +555,7 @@ CA
                     </connections>
                 </button>
                 <secureTextField verticalHuggingPriority="750" horizontalCompressionResistancePriority="249" translatesAutoresizingMaskIntoConstraints="NO" id="60" customClass="HNHRoundedSecureTextField">
-                    <rect key="frame" x="20" y="179" width="173" height="24"/>
+                    <rect key="frame" x="20" y="235" width="173" height="24"/>
                     <autoresizingMask key="autoresizingMask" flexibleMaxX="YES" flexibleMinY="YES"/>
                     <secureTextFieldCell key="cell" scrollable="YES" lineBreakMode="clipping" selectable="YES" editable="YES" sendsActionOnEndEditing="YES" borderStyle="bezel" drawsBackground="YES" usesSingleLineMode="YES" id="63">
                         <font key="font" size="13" name="Menlo-Regular"/>
@@ -570,7 +570,7 @@ CA
                     </connections>
                 </secureTextField>
                 <button verticalHuggingPriority="750" translatesAutoresizingMaskIntoConstraints="NO" id="61">
-                    <rect key="frame" x="201" y="177" width="31" height="25"/>
+                    <rect key="frame" x="201" y="233" width="31" height="25"/>
                     <autoresizingMask key="autoresizingMask" flexibleMaxX="YES" flexibleMinY="YES"/>
                     <buttonCell key="cell" type="roundTextured" bezelStyle="texturedRounded" image="NSQuickLookTemplate" imagePosition="only" alignment="center" borderStyle="border" imageScaling="proportionallyDown" inset="2" id="62">
                         <behavior key="behavior" pushIn="YES" changeContents="YES" lightByContents="YES"/>
@@ -583,6 +583,9 @@ CA
                 <button horizontalCompressionResistancePriority="250" translatesAutoresizingMaskIntoConstraints="NO" id="7">
                     <rect key="frame" x="18" y="129" width="67" height="18"/>
                     <autoresizingMask key="autoresizingMask" flexibleMaxX="YES" flexibleMinY="YES"/>
+                    <constraints>
+                        <constraint firstAttribute="height" constant="14" id="vgc-Xu-RJs"/>
+                    </constraints>
                     <buttonCell key="cell" type="check" title="Expires" bezelStyle="regularSquare" imagePosition="left" lineBreakMode="truncatingMiddle" state="on" inset="2" id="78">
                         <behavior key="behavior" changeContents="YES" doesNotDimImage="YES" lightByContents="YES"/>
                         <font key="font" metaFont="system"/>
@@ -640,13 +643,11 @@ CA
                 <constraint firstItem="55" firstAttribute="top" secondItem="54" secondAttribute="bottom" constant="8" symbolic="YES" id="19"/>
                 <constraint firstAttribute="trailing" secondItem="55" secondAttribute="trailing" constant="20" symbolic="YES" id="20"/>
                 <constraint firstItem="57" firstAttribute="leading" secondItem="4" secondAttribute="leading" constant="20" symbolic="YES" id="21"/>
-                <constraint firstItem="57" firstAttribute="top" secondItem="55" secondAttribute="bottom" constant="12" id="22"/>
                 <constraint firstItem="56" firstAttribute="leading" secondItem="4" secondAttribute="leading" constant="20" symbolic="YES" id="23"/>
                 <constraint firstItem="56" firstAttribute="top" secondItem="57" secondAttribute="bottom" constant="8" symbolic="YES" id="24"/>
                 <constraint firstAttribute="trailing" secondItem="56" secondAttribute="trailing" constant="20" symbolic="YES" id="25"/>
                 <constraint firstItem="58" firstAttribute="leading" secondItem="4" secondAttribute="leading" constant="20" symbolic="YES" id="26"/>
                 <constraint firstItem="58" firstAttribute="trailing" secondItem="54" secondAttribute="trailing" id="27"/>
-                <constraint firstItem="58" firstAttribute="top" secondItem="56" secondAttribute="bottom" constant="12" id="28"/>
                 <constraint firstItem="60" firstAttribute="top" secondItem="58" secondAttribute="bottom" constant="8" symbolic="YES" id="29"/>
                 <constraint firstItem="60" firstAttribute="leading" secondItem="4" secondAttribute="leading" constant="20" symbolic="YES" id="30"/>
                 <constraint firstItem="59" firstAttribute="top" secondItem="61" secondAttribute="bottom" constant="8" symbolic="YES" id="31"/>
@@ -663,9 +664,11 @@ CA
                 <constraint firstItem="5" firstAttribute="top" secondItem="6" secondAttribute="bottom" constant="8" symbolic="YES" id="48"/>
                 <constraint firstItem="5" firstAttribute="leading" secondItem="4" secondAttribute="leading" constant="20" symbolic="YES" id="49"/>
                 <constraint firstAttribute="trailing" secondItem="5" secondAttribute="trailing" constant="20" symbolic="YES" id="50"/>
-                <constraint firstAttribute="bottom" secondItem="5" secondAttribute="bottom" constant="20" symbolic="YES" id="51"/>
-                <constraint firstItem="7" firstAttribute="top" secondItem="59" secondAttribute="bottom" constant="8" symbolic="YES" id="QPJ-9m-AzZ"/>
+                <constraint firstItem="7" firstAttribute="top" secondItem="56" secondAttribute="bottom" constant="12" id="Gh9-Lg-kcm"/>
+                <constraint firstItem="58" firstAttribute="top" secondItem="55" secondAttribute="bottom" constant="12" id="JiM-Dm-AG8"/>
                 <constraint firstItem="8" firstAttribute="leading" relation="greaterThanOrEqual" secondItem="7" secondAttribute="trailing" constant="8" symbolic="YES" id="Xa5-Ir-XNC"/>
+                <constraint firstAttribute="bottom" secondItem="5" secondAttribute="bottom" constant="20" symbolic="YES" id="bPh-V3-4rv"/>
+                <constraint firstItem="57" firstAttribute="top" secondItem="59" secondAttribute="bottom" constant="8" symbolic="YES" id="lYe-am-xJx"/>
             </constraints>
         </customView>
         <view translatesAutoresizingMaskIntoConstraints="NO" id="zv7-wE-Bmg" customClass="HNHScrollDocumentViewAdapter">
diff --git a/MacPass/EntryView.xib b/MacPass/EntryView.xib
index 3a7e32e7..8a5bf319 100644
--- a/MacPass/EntryView.xib
+++ b/MacPass/EntryView.xib
@@ -27,7 +27,7 @@
                         <rect key="frame" x="0.0" y="17" width="694" height="548"/>
                         <autoresizingMask key="autoresizingMask" widthSizable="YES" heightSizable="YES"/>
                         <subviews>
-                            <tableView verticalHuggingPriority="750" allowsExpansionToolTips="YES" columnAutoresizingStyle="lastColumnOnly" alternatingRowBackgroundColors="YES" columnReordering="NO" columnSelection="YES" multipleSelection="NO" rowSizeStyle="automatic" headerView="676" viewBased="YES" id="55" customClass="MPTableView">
+                            <tableView verticalHuggingPriority="750" allowsExpansionToolTips="YES" columnAutoresizingStyle="lastColumnOnly" alternatingRowBackgroundColors="YES" columnSelection="YES" multipleSelection="NO" rowSizeStyle="automatic" headerView="676" viewBased="YES" id="55" customClass="MPTableView">
                                 <rect key="frame" x="0.0" y="0.0" width="694" height="548"/>
                                 <autoresizingMask key="autoresizingMask"/>
                                 <size key="intercellSpacing" width="3" height="2"/>
diff --git a/MacPass/GroupInspectorView.xib b/MacPass/GroupInspectorView.xib
index c2b05037..058e848d 100644
--- a/MacPass/GroupInspectorView.xib
+++ b/MacPass/GroupInspectorView.xib
@@ -18,19 +18,19 @@
         </customObject>
         <customObject id="-1" userLabel="First Responder" customClass="FirstResponder"/>
         <customObject id="-3" userLabel="Application"/>
-        <scrollView borderType="none" horizontalLineScroll="10" horizontalPageScroll="10" verticalLineScroll="10" verticalPageScroll="10" hasVerticalScroller="NO" usesPredominantAxisScrolling="NO" translatesAutoresizingMaskIntoConstraints="NO" id="37" customClass="HNHScrollView">
-            <rect key="frame" x="0.0" y="0.0" width="257" height="201"/>
+        <scrollView borderType="none" horizontalLineScroll="10" horizontalPageScroll="10" verticalLineScroll="10" verticalPageScroll="10" hasHorizontalScroller="NO" hasVerticalScroller="NO" usesPredominantAxisScrolling="NO" translatesAutoresizingMaskIntoConstraints="NO" id="37" customClass="HNHScrollView">
+            <rect key="frame" x="0.0" y="0.0" width="257" height="205"/>
             <autoresizingMask key="autoresizingMask" flexibleMaxX="YES" flexibleMinY="YES"/>
             <clipView key="contentView" id="HjA-kA-fcX">
-                <rect key="frame" x="0.0" y="0.0" width="257" height="201"/>
+                <rect key="frame" x="0.0" y="0.0" width="257" height="205"/>
                 <autoresizingMask key="autoresizingMask" widthSizable="YES" heightSizable="YES"/>
                 <subviews>
                     <view translatesAutoresizingMaskIntoConstraints="NO" id="38" customClass="HNHScrollDocumentViewAdapter">
-                        <rect key="frame" x="0.0" y="0.0" width="257" height="201"/>
+                        <rect key="frame" x="0.0" y="0.0" width="257" height="205"/>
                         <autoresizingMask key="autoresizingMask" widthSizable="YES" heightSizable="YES"/>
                         <subviews>
                             <textField verticalHuggingPriority="750" translatesAutoresizingMaskIntoConstraints="NO" id="24">
-                                <rect key="frame" x="18" y="182" width="35" height="14"/>
+                                <rect key="frame" x="18" y="186" width="35" height="14"/>
                                 <autoresizingMask key="autoresizingMask" flexibleMaxX="YES" flexibleMinY="YES"/>
                                 <textFieldCell key="cell" controlSize="small" scrollable="YES" lineBreakMode="clipping" sendsActionOnEndEditing="YES" title="Name" id="25">
                                     <font key="font" metaFont="smallSystem"/>
@@ -39,7 +39,7 @@
                                 </textFieldCell>
                             </textField>
                             <textField verticalHuggingPriority="750" horizontalCompressionResistancePriority="249" translatesAutoresizingMaskIntoConstraints="NO" id="23" customClass="HNHRoundedTextField">
-                                <rect key="frame" x="20" y="152" width="217" height="22"/>
+                                <rect key="frame" x="20" y="156" width="217" height="22"/>
                                 <autoresizingMask key="autoresizingMask" flexibleMaxX="YES" flexibleMinY="YES"/>
                                 <textFieldCell key="cell" lineBreakMode="truncatingTail" truncatesLastVisibleLine="YES" selectable="YES" editable="YES" sendsActionOnEndEditing="YES" state="on" borderStyle="bezel" drawsBackground="YES" usesSingleLineMode="YES" id="26">
                                     <font key="font" metaFont="system"/>
@@ -127,7 +127,7 @@
                             <constraint firstAttribute="trailing" secondItem="4" secondAttribute="trailing" constant="20" id="D99-L7-ojR"/>
                             <constraint firstItem="240" firstAttribute="leading" secondItem="38" secondAttribute="leading" constant="20" id="E0a-1e-KR9"/>
                             <constraint firstItem="5" firstAttribute="centerY" secondItem="4" secondAttribute="centerY" id="FdF-Pn-yY2"/>
-                            <constraint firstItem="5" firstAttribute="top" secondItem="23" secondAttribute="bottom" constant="8" symbolic="YES" id="GFF-xs-Nuj"/>
+                            <constraint firstItem="5" firstAttribute="top" secondItem="23" secondAttribute="bottom" constant="12" id="GFF-xs-Nuj"/>
                             <constraint firstItem="4" firstAttribute="leading" relation="greaterThanOrEqual" secondItem="5" secondAttribute="trailing" constant="8" symbolic="YES" id="HDo-Yu-P02"/>
                             <constraint firstItem="24" firstAttribute="leading" secondItem="38" secondAttribute="leading" constant="20" id="OhC-BP-oPg"/>
                             <constraint firstAttribute="trailing" secondItem="240" secondAttribute="trailing" constant="20" symbolic="YES" id="V4d-R9-46P"/>
@@ -152,12 +152,12 @@
                     <constraint firstItem="38" firstAttribute="leading" secondItem="HjA-kA-fcX" secondAttribute="leading" id="h7m-U5-sA4"/>
                 </constraints>
             </clipView>
-            <scroller key="horizontalScroller" verticalHuggingPriority="750" horizontal="YES" id="39">
-                <rect key="frame" x="0.0" y="185" width="257" height="16"/>
+            <scroller key="horizontalScroller" hidden="YES" verticalHuggingPriority="750" horizontal="YES" id="39">
+                <rect key="frame" x="-100" y="-100" width="257" height="16"/>
                 <autoresizingMask key="autoresizingMask"/>
             </scroller>
             <scroller key="verticalScroller" hidden="YES" verticalHuggingPriority="750" doubleValue="1" horizontal="NO" id="40">
-                <rect key="frame" x="-100" y="-100" width="16" height="413"/>
+                <rect key="frame" x="-100" y="-100" width="15" height="201"/>
                 <autoresizingMask key="autoresizingMask"/>
             </scroller>
         </scrollView>
diff --git a/MacPass/MPEntryViewController.m b/MacPass/MPEntryViewController.m
index ef41b396..35fd9028 100644
--- a/MacPass/MPEntryViewController.m
+++ b/MacPass/MPEntryViewController.m
@@ -522,7 +522,7 @@ NSString *const _MPTAbleSecurCellView = @"PasswordCell";
   for(NSMenuItem *item in [headerMenu itemArray]) {
     NSUInteger index = [headerMenu indexOfItem:item];
     NSTableColumn *column= [self.entryTable tableColumnWithIdentifier:identifier[index]];
-    [item bind:NSValueBinding toObject:column withKeyPath:@"hidden" options:options];
+    [item bind:NSValueBinding toObject:column withKeyPath:NSHiddenBinding options:options];
   }
   
   [[self.entryTable headerView] setMenu:headerMenu];
diff --git a/MacPass/MPToolbarDelegate.m b/MacPass/MPToolbarDelegate.m
index 15542831..c2767a01 100644
--- a/MacPass/MPToolbarDelegate.m
+++ b/MacPass/MPToolbarDelegate.m
@@ -242,13 +242,13 @@ NSString *const MPToolbarItemSearch = @"TOOLBAR_SEARCH";
 }
 
 - (NSMenu *)_allocateSearchMenuTemplate {
-  NSMenu *menu = [[NSMenu alloc] initWithTitle:NSLocalizedString(@"SEARCH_MENU", @"")];
+  NSMenu *menu = [[NSMenu alloc] init];
   NSMenuItem *item = [[NSMenuItem alloc] initWithTitle:NSLocalizedString(@"CLEAR_RECENT_SEARCHES", @"") action:NULL keyEquivalent:@""];
   [item setTag:NSSearchFieldClearRecentsMenuItemTag];
   [menu addItem:item];
   
   [menu addItem:[NSMenuItem separatorItem]];
-  
+
   item = [[NSMenuItem alloc] initWithTitle:NSLocalizedString(@"RECENT_SEARCHES", @"") action:NULL keyEquivalent:@""];
   [item setTag:NSSearchFieldRecentsTitleMenuItemTag];
   [menu addItem:item];
diff --git a/MacPass/de.lproj/Localizable.strings b/MacPass/de.lproj/Localizable.strings
index fab1007df139272da0229f9341af383ddbb51ddf..284f207fe7f601f08f947d8de5bc207fd978e7fb 100644
GIT binary patch
delta 628
zcmb7BJx{_=6g{Acp(Zk*!Ri7{j0uaAgBlYF)cAp5EQvUgMhX(48lXm9_ycb5FSwXE
z7`yrpoSdB8Saf%C@x0d(SR73A-n;MJdp_>%{r27dQz5!+po|g@xQ_Uha0~+}Y;qZV
zy+8*IIB>;lL>G?{ZKBEeCz9@$P=tx9LKexfGlpXg@ebtapv_n^xv<e=)dn=~L;ML@
zvQ!?a4$(vG9&u;%5g;|JAcK@|MIWa67U^xKPFbK)Cc~s8&!G^~R!MF0Zqja<cCGL|
zN5dv>BiRDEdbs6s$YjA&tTt`esbB|VP;I%ask5q6QT@50GvnV<e+v1Zv2JWNXjS%=
zSEF;-U715|D~EYTU0kBY+zq3!e{qud5R>{#{7O2+fEH^q5^s89&0x<J9AZ~lwK$Kg
zno3@s@^>y_YiuR~M;!w{J^LON&(jNHCV9P>#W_ddQMjc{G?kP`sfG|qFK#g_2Up|X
OK~2offBRqhdh8dl-g4;x

delta 117
zcmeD2UgEaFhiS7B^9J_KXSfqMC#Q(s+MFeRh>6#oA(bHyh>I8!8FD7uN;UF^G88bR
z0C^=q(c;NBrAm2SfUGp2NGU@OL&@Y=>93Pr#I{K%0Ywvm`apChSak`56@vnUDucsj
IXBkgU04#qX4gdfE

diff --git a/MacPass/en.lproj/Localizable.strings b/MacPass/en.lproj/Localizable.strings
index 1fb25131e8296db442ce807cfd0b5d523f6e19f8..f1373a7edd1ea6fa4a4cd1f395ab3bab5885a19a 100644
GIT binary patch
delta 224
zcmez2a?EXm3s-$GLn=ceLlHwVLk0sEg93vVgFcW}VsK{gVQ^(|WC&u22Vz$s-<83S
zAq2<^hKf5gcmP?!K(z`Cwm=NhlLIwP0cc_>(9BeZJcbgWTrrX@sX(3*gEiQeAO|9i
h4#H*JW__;foRe2E^Gp^JIm75X`MyZ(W+zcIUI6GrD8K*!

delta 35
rcmX@+_QPd^3)f}|?n9i6$&+u3TxZOkyje7sRe>Rqp=2|^m^m*1_bChE

diff --git a/MacPass/fr.lproj/Localizable.strings b/MacPass/fr.lproj/Localizable.strings
index b5e7b30b017ee9776ba941ffc7c4440172059e31..73031cbf0d60681d1f18905add304e2b326c2181 100644
GIT binary patch
delta 575
zcma)3T}#4H7=92U+qDquY7Dv&!mF-CP_|K#Io$-an=#@*VmWbwbmfn*9}?`J_y@X+
z5JdU|(sK^8EhLJU_k6zZ^Ks7d;-&d|SD2gV!o>~KW4P$Sgn=4U-b8p}P8bnpJgGwC
z=%NJ&0c#z`b*^K85j!J}g7b`{z;LfmvbBhQ3A6i6_On&ejxfc;UUQ$64NA>qW}OC}
zNf;)b!sp@KmrE+YCx}LxGAc^Fg=Pv75XOPUlxhO_>A6K^4tE)ag~t@lAfh0qQ1T4K
zITpd)?v1?qKcT(f;F2?Kb9Amzby?}R>1N8}3bhXSFY<+Lu40U-E~NE%=X0T#-WFT^
m-8CuV7HwQ9r#?M4lv7*H@()i@&-whLI$4*F50cf%NAU|9YF{n@

delta 38
wcmV+>0NMYPOwvcNS^~2+1Ly~{@(bDtlLQvrljsW!qbwK&ljauSvnCzx2s~;J)&Kwi