nikdoof/MacPass
1
1
Fork 0
mirror of https://github.com/MacPass/MacPass.git synced 2025-12-14 16:22:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

Extracted column actions into seperate methods

Browse Source
This commit is contained in:
michael starke
2014-08-18 01:56:39 +02:00
parent 2b1de3d63b
commit 6231e192af
1 changed files with 29 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

50
MacPass/MPEntryViewController.m
View File

@@ -660,17 +660,7 @@ NSString *const _MPTAbleSecurCellView = @"PasswordCell";
NSTableColumn *column = [self.entryTable tableColumns][[self.entryTable clickedColumn]]; NSTableColumn *column = [self.entryTable tableColumns][[self.entryTable clickedColumn]];
NSString *identifier = [column identifier]; NSString *identifier = [column identifier];
if([identifier isEqualToString:MPEntryTableTitleColumnIdentifier]) { if([identifier isEqualToString:MPEntryTableTitleColumnIdentifier]) {
MPDoubleClickTitleAction action = [[NSUserDefaults standardUserDefaults] integerForKey:kMPSettingsKeyDoubleClickTitleAction]; [self _executeTitleColumnDoubleClick];
if (action == MPDoubleClickTitleActionInspect) {
[[self windowController] showInspector:nil];
}
else if (action == MPDoubleClickTitleActionIgnore) {
}
else {
NSLog(@"Unknown double click action");
}
} }
else if([identifier isEqualToString:MPEntryTablePasswordColumnIdentifier]) { else if([identifier isEqualToString:MPEntryTablePasswordColumnIdentifier]) {
[self copyPassword:nil]; [self copyPassword:nil];
@@ -679,18 +669,36 @@ NSString *const _MPTAbleSecurCellView = @"PasswordCell";
[self copyUsername:nil]; [self copyUsername:nil];
} }
else if([identifier isEqualToString:MPEntryTableURLColumnIdentifier]) { else if([identifier isEqualToString:MPEntryTableURLColumnIdentifier]) {
MPDoubleClickURLAction action = [[NSUserDefaults standardUserDefaults] integerForKey:kMPSettingsKeyDoubleClickURLAction]; [self _executeURLColumnDoubleClick];
if(action == MPDoubleClickURLActionOpen) {
[self openURL:nil];
}
else if (action == MPDoubleClickURLActionCopy) {
[self copyURL:nil];
}
else {
NSLog(@"Unknown double click URL action");
}
} }
// TODO: Add more actions for new columns // TODO: Add more actions for new columns
} }
- (void)_executeTitleColumnDoubleClick {
MPDoubleClickTitleAction action = [[NSUserDefaults standardUserDefaults] integerForKey:kMPSettingsKeyDoubleClickTitleAction];
switch(action) {
case MPDoubleClickTitleActionInspect:
[[self windowController] showInspector:nil];
break;
case MPDoubleClickTitleActionIgnore:
break;
default:
NSLog(@"Unknown double click title action");
break;
}
}
- (void)_executeURLColumnDoubleClick {
MPDoubleClickURLAction action = [[NSUserDefaults standardUserDefaults] integerForKey:kMPSettingsKeyDoubleClickURLAction];
switch (action) {
case MPDoubleClickURLActionOpen:
[self openURL:nil];
break;
case MPDoubleClickURLActionCopy:
[self copyURL:nil];
break;
default:
NSLog(@"Unknown double click URL action");
break;
}
}
@end @end