diff --git a/KeePassKit b/KeePassKit index 8b7349b8..fb6b52e8 160000 --- a/KeePassKit +++ b/KeePassKit @@ -1 +1 @@ -Subproject commit 8b7349b85675eb2ca863222c951028c35b8854a8 +Subproject commit fb6b52e86f8e6835ce6d8ccc00f438fbdf48fefc diff --git a/MacPass/EntryInspectorView.xib b/MacPass/EntryInspectorView.xib index db1549bd..34328a9b 100644 --- a/MacPass/EntryInspectorView.xib +++ b/MacPass/EntryInspectorView.xib @@ -13,7 +13,6 @@ - @@ -32,7 +31,7 @@ - + @@ -40,7 +39,7 @@ - + @@ -432,45 +431,58 @@ - + - + - - + + + + + + + + + + + + + + + + + + + + + + + + - - + + - + - - - - - - - - - - - - - - + @@ -482,25 +494,96 @@ - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + - - - - + + + + + + + + + + + + + + + + + + + + + + + + + + + diff --git a/MacPass/MPAppDelegate.m b/MacPass/MPAppDelegate.m index a2e65eb9..cd831924 100644 --- a/MacPass/MPAppDelegate.m +++ b/MacPass/MPAppDelegate.m @@ -62,6 +62,7 @@ NSString *const MPDidChangeStoredKeyFilesSettings = @"com.hicknhack.macpass.MPDi } - (void)dealloc { + [self unbind:@"isAllowedToStoreKeyFile"]; [[NSNotificationCenter defaultCenter] removeObserver:self]; } diff --git a/MacPass/MPDocument.m b/MacPass/MPDocument.m index dddbf246..cda5206c 100644 --- a/MacPass/MPDocument.m +++ b/MacPass/MPDocument.m @@ -117,7 +117,6 @@ NSString *const MPDocumentGroupKey = @"MPDocumentGroupKey } - (void)dealloc { - [self unbind:@"isAllowedToStoreKeyFile"]; [self _cleanupLock]; } diff --git a/MacPass/MPEntryInspectorViewController.h b/MacPass/MPEntryInspectorViewController.h index 8e827b58..91a44509 100644 --- a/MacPass/MPEntryInspectorViewController.h +++ b/MacPass/MPEntryInspectorViewController.h @@ -24,7 +24,6 @@ @property (weak) IBOutlet NSSegmentedControl *infoTabControl; @property (weak) IBOutlet NSTableView *attachmentTableView; @property (weak) IBOutlet NSTableView *customFieldsTableView; -@property (weak) IBOutlet NSTableView *historyTableView; @property (unsafe_unretained) IBOutlet NSTextView *notesTextView; @property (weak) IBOutlet NSButton *generatePasswordButton; @property (weak) IBOutlet NSButton *togglePassword; diff --git a/MacPass/MPEntryInspectorViewController.m b/MacPass/MPEntryInspectorViewController.m index c89b2542..22af7419 100644 --- a/MacPass/MPEntryInspectorViewController.m +++ b/MacPass/MPEntryInspectorViewController.m @@ -25,14 +25,13 @@ typedef NS_ENUM(NSUInteger, MPEntryTab) { MPEntryTabGeneral, MPEntryTabFiles, MPEntryTabCustomFields, - MPEntryTabHistory + MPEntryTabAutotype }; @interface MPEntryInspectorViewController () { @private NSArrayController *_attachmentsController; NSArrayController *_customFieldsController; - NSArrayController *_historyController; MPAttachmentTableViewDelegate *_attachmentTableDelegate; MPCustomFieldTableViewDelegate *_customFieldTableDelegate; MPAttachmentTableDataSource *_attachmentDataSource; @@ -59,7 +58,6 @@ typedef NS_ENUM(NSUInteger, MPEntryTab) { _showPassword = NO; _attachmentsController = [[NSArrayController alloc] init]; _customFieldsController = [[NSArrayController alloc] init]; - _historyController = [[NSArrayController alloc] init]; _attachmentTableDelegate = [[MPAttachmentTableViewDelegate alloc] init]; _customFieldTableDelegate = [[MPCustomFieldTableViewDelegate alloc] init]; _attachmentDataSource = [[MPAttachmentTableDataSource alloc] init]; @@ -121,8 +119,6 @@ typedef NS_ENUM(NSUInteger, MPEntryTab) { [_customFieldsTableView bind:NSContentBinding toObject:_customFieldsController withKeyPath:@"arrangedObjects" options:nil]; [_customFieldsTableView setDelegate:_customFieldTableDelegate]; - [_historyTableView bind:NSContentBinding toObject:_historyController withKeyPath:@"arrangedObjects" options:nil]; - [self.passwordTextField bind:@"showPassword" toObject:self withKeyPath:@"showPassword" options:nil]; [self.togglePassword bind:NSValueBinding toObject:self withKeyPath:@"showPassword" options:nil]; } @@ -237,7 +233,6 @@ typedef NS_ENUM(NSUInteger, MPEntryTab) { [self _bindEntry]; [self _bindAttachments]; [self _bindCustomFields]; - [self _bindHistory]; } - (void)_bindEntry { @@ -275,16 +270,6 @@ typedef NS_ENUM(NSUInteger, MPEntryTab) { [_customFieldsController bind:NSContentArrayBinding toObject:self.entry withKeyPath:@"customAttributes" options:nil]; } -- (void)_bindHistory { - if(self.entry) { - [_historyController bind:NSContentArrayBinding toObject:self.entry withKeyPath:@"history" options:nil]; - } - else if([_historyController content] != nil) { - [_historyController unbind:NSContentArrayBinding]; - [_historyController setContent:nil]; - } -} - - (void)_toggleEditing:(BOOL)edit { /* TODO: not fully working right now */ diff --git a/MacPass/SavePanelAccessoryView.xib b/MacPass/SavePanelAccessoryView.xib index ddbcc1d7..8997e65b 100644 --- a/MacPass/SavePanelAccessoryView.xib +++ b/MacPass/SavePanelAccessoryView.xib @@ -1,630 +1,68 @@ - - - - 1080 - 12E55 - 3084 - 1187.39 - 626.00 - - com.apple.InterfaceBuilder.CocoaPlugin - 3084 - - - IBNSLayoutConstraint - NSCustomObject - NSCustomView - NSMenu - NSMenuItem - NSPopUpButton - NSPopUpButtonCell - NSTextField - NSTextFieldCell - - - com.apple.InterfaceBuilder.CocoaPlugin - - - PluginDependencyRecalculationVersion - - - - - MPSavePanelAccessoryViewController - - - FirstResponder - - - NSApplication - - - - 268 - - - - 268 - {{126, 20}, {363, 28}} - - - _NS:1535 - {249, 750} - YES - - 67108864 - 272629760 - Not all Information inside your current database can be stored with this format. - - LucidaGrande - 11 - 3100 - - _NS:1535 - - - 6 - System - controlColor - - 3 - MC42NjY2NjY2NjY3AA - - - - 6 - System - controlTextColor - - 3 - MAA - - - - NO - - - - 268 - {{126, 58}, {53, 17}} - - - - _NS:1535 - YES - - 68157504 - 272630784 - Format: - - LucidaGrande - 13 - 1044 - - _NS:1535 - - - - - NO - - - - 268 - {{182, 53}, {144, 26}} - - - - _NS:9 - YES - - -2076180416 - 2048 - - _NS:9 - - 109199360 - 129 - - - 400 - 75 - - - KeePass 1 (KDB) - - 1048576 - 2147483647 - 1 - - NSImage - NSMenuCheckmark - - - NSImage - NSMenuMixedState - - _popUpItemAction: - - - YES - - OtherViews - - - - - KeePass 2 (KDBX) - - 1048576 - 2147483647 - - - _popUpItemAction: - - - - - - -1 - 1 - YES - YES - 2 - - NO - - - {506, 95} - - - - NSView - - - - - - - view - - - - 106 - - - - fileTypePopupButton - - - - 107 - - - - infoTextField - - - - 108 - - - - - - 0 - - - - - - -2 - - - File's Owner - - - -1 - - - First Responder - - - -3 - - - Application - - - 1 - - - - - 5 - 0 - - 6 - 1 - - 8 - - 1000 - - 6 - 24 - 3 - - - - 9 - 0 - - 9 - 1 - - 0.0 - - 1000 - - 9 - 40 - 2 - - - - 10 - 0 - - 10 - 1 - - 0.0 - - 1000 - - 9 - 40 - 2 - - - - 6 - 1 - - 6 - 1 - - 20 - - 1000 - - 9 - 40 - 3 - - - - 4 - 1 - - 4 - 1 - - 20 - - 1000 - - 9 - 40 - 3 - - - - 3 - 0 - - 4 - 1 - - 8 - - 1000 - - 9 - 40 - 3 - - - - 5 - 0 - - 5 - 1 - - 0.0 - - 1000 - - 6 - 24 - 2 - - - - 6 - 0 - - 6 - 1 - - 20 - - 1000 - - 9 - 40 - 3 - - - - 3 - 0 - - 3 - 1 - - 20 - - 1000 - - 9 - 40 - 3 - - - - 5 - 1 - - 5 - 1 - - 20 - - 1000 - - 9 - 40 - 3 - - - - - - - - - 2 - - - - - - - - 3 - - - - - - - - 4 - - - - - - - - - 5 - - - - - 6 - - - - - 11 - - - - - - - - 12 - - - - - 51 - - - - - - - - 52 - - - - - 80 - - - - - 81 - - - - - 86 - - - - - 91 - - - - - 78 - - - - - 101 - - - - - 89 - - - - - 103 - - - - - 92 - - - - - 95 - - - - - - - com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin - - - - - - - - - - - - - com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin - - com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin - - com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin - - com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin - - - - - - 108 - - - - - MPSavePanelAccessoryViewController - MPViewController - - setFileType: - id - - - setFileType: - - setFileType: - id - - - - NSPopUpButton - NSTextField - - - - fileTypePopupButton - NSPopUpButton - - - infoTextField - NSTextField - - - - IBProjectSource - ./Classes/MPSavePanelAccessoryViewController.h - - - - MPViewController - NSViewController - - IBProjectSource - ./Classes/MPViewController.h - - - - NSLayoutConstraint - NSObject - - IBProjectSource - ./Classes/NSLayoutConstraint.h - - - - - 0 - IBCocoaFramework - YES - 3 - - {11, 11} - {10, 3} - - YES - - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + \ No newline at end of file diff --git a/MacPass/UnprotectedWarningView.xib b/MacPass/UnprotectedWarningView.xib index 0a9c6e3e..91994252 100644 --- a/MacPass/UnprotectedWarningView.xib +++ b/MacPass/UnprotectedWarningView.xib @@ -1,5 +1,5 @@ - + diff --git a/MacPassTests/KPKTestPlaceholder.m b/MacPassTests/KPKTestPlaceholder.m index 40a56644..5af242f0 100644 --- a/MacPassTests/KPKTestPlaceholder.m +++ b/MacPassTests/KPKTestPlaceholder.m @@ -10,7 +10,7 @@ #import "KPKEntry.h" #import "KPKAttribute.h" -#import "NSString+Placeholder.h" +#import "NSString+Commands.h" @implementation KPKTextPlaceholder