From 2a1e88a97a324099b920b07b9df90905f92cfb3f Mon Sep 17 00:00:00 2001 From: michael starke Date: Thu, 2 Nov 2017 17:57:01 +0100 Subject: [PATCH] fixed menu item duplication for NSSecureTextFields --- MacPass/MPEntryInspectorViewController.m | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/MacPass/MPEntryInspectorViewController.m b/MacPass/MPEntryInspectorViewController.m index 926932bd..0cef048c 100644 --- a/MacPass/MPEntryInspectorViewController.m +++ b/MacPass/MPEntryInspectorViewController.m @@ -516,7 +516,11 @@ typedef NS_ENUM(NSUInteger, MPEntryTab) { #pragma mark - #pragma mark HNHUITextFieldDelegate - (NSMenu *)textField:(NSTextField *)textField textView:(NSTextView *)view menu:(NSMenu *)menu { - + for(NSMenuItem *item in [menu itemArray]) { + if(item.action == @selector(showReferenceBuilder:)) { + return menu; // item is already contained! + } + } NSMenuItem *item = [[NSMenuItem alloc] initWithTitle:NSLocalizedString(@"SHOW_REFERENCE_BUILDER", @"Menu item to show the reference builder in a text view's context menu")action:@selector(showReferenceBuilder:) keyEquivalent:@""]; item.representedObject = textField; [menu addItem:item];