Fixed memory leaks

Removed obsolete CreationViewController references

MacPass/MPAppDelegate.m

@@ -50,6 +50,7 @@
 - (void)dealloc {
   [_settingsController release];
   [_passwordCreatorController release];
+  [_passwordCreatorWindow release];
   [serverDaemon release];
   [lockDaemon release];
   [super dealloc];

MacPass/MPDocument.h

@@ -36,7 +36,7 @@ APPKIT_EXTERN NSString *const MPDocumentGroupKey;
 @property (assign, readonly, getter = isDecrypted) BOOL decrypted;
 @property (retain, readonly) KdbTree *tree;
 @property (assign, readonly, nonatomic) KdbGroup *root;
-@property (nonatomic,retain) NSString *password;
+@property (nonatomic, retain) NSString *password;
 @property (nonatomic, retain) NSURL *key;
 @property (assign, readonly) MPDatabaseVersion version;
 

MacPass/MPDocument.m

@@ -70,6 +70,13 @@ NSString *const MPDocumentGroupKey                    = @"MPDocumentGroupKey";
   return self;
 }
 
+- (void)dealloc {
+  [_tree release];
+  [_password release];
+  [_key release];
+  [super dealloc];
+}
+
 - (void)makeWindowControllers {
   MPDocumentWindowController *windowController = [[MPDocumentWindowController alloc] init];
   [self addWindowController:windowController];

MacPass/MPDocumentWindowController.h

@@ -14,7 +14,6 @@
 @class MPPasswordEditViewController;
 @class MPPasswordInputController;
 @class MPOutlineViewController;
-@class MPCreationViewController;
 
 @class KdbGroup;
 @class KdbEntry;
@@ -28,7 +27,7 @@ APPKIT_EXTERN NSString *const MPCurrentItemChangedNotification;
 @property (readonly, retain) MPEntryViewController *entryViewController;
 @property (readonly, retain) MPOutlineViewController *outlineViewController;
 @property (readonly, retain) MPInspectorViewController *inspectorViewController;
-@property (readonly, retain) MPCreationViewController *creationViewController;
+
 
 /* Holds the current item. That is either a KdbGroup or a KdbEntry */
 @property (readonly, assign) id currentItem;

MacPass/MPDocumentWindowController.m

@@ -39,7 +39,6 @@ NSString *const MPCurrentItemChangedNotification = @"com.hicknhack.macpass.MPCur
 
 @property (retain) MPToolbarDelegate *toolbarDelegate;
 
-
 @end
 
 @implementation MPDocumentWindowController
@@ -67,10 +66,10 @@ NSString *const MPCurrentItemChangedNotification = @"com.hicknhack.macpass.MPCur
   [_toolbar release];
   
   [_passwordInputController release];
+  [_passwordEditController release];
   [_entryViewController release];
   [_outlineViewController release];
   [_inspectorViewController release];
-  [_creationViewController release];
   
   [_toolbarDelegate release];
   [_splitView release];

MacPass/MPEntryViewController.h

@@ -17,12 +17,12 @@ APPKIT_EXTERN NSString *const MPEntryTableURLColumnIdentifier;
 APPKIT_EXTERN NSString *const MPDidChangeSelectedEntryNotification;
 
 /* Tags to determine what to copy */
-typedef enum {
+typedef NS_ENUM( NSUInteger, MPCopyContentTypeTag) {
   MPCopyUsername,
   MPCopyPassword,
   MPCopyURL,
   MPCopyWholeEntry,
-} MPCopyContentTypeTag;
+};
 
 @class KdbGroup;
 @class KdbEntry;

MacPass/MPEntryViewController.m

@@ -111,12 +111,13 @@ NSString *const _toggleFilterUsernameButton = @"SearchUsername";
 - (void)dealloc {
   [[NSNotificationCenter defaultCenter] removeObserver:self];
   
-  self.entryArrayController = nil;
+  [_entryArrayController release];
-  self.filteredEntries = nil;
+  [_filteredEntries release];
-  self.filterBar = nil;
+  [_filter release];
-  self.tableToTop = nil;
+  [_filterBar release];
-  self.filterButtonToMode = nil;
+  [_tableToTop release];
-  self.dataSource = nil;
+  [_dataSource release];
+  [_filterButtonToMode release];
   [super dealloc];
 }
 

MacPass/MPInspectorViewController.m

@@ -69,6 +69,7 @@ enum {
 - (void)dealloc {
   [[NSNotificationCenter defaultCenter] removeObserver:self];
   [_activePopover release];
+  [_attachmentsController release];
   [super dealloc];
 }
 

MacPass/MPOutlineViewController.m

@@ -56,6 +56,13 @@ NSString *const _MPOutlinveViewHeaderViewIdentifier = @"HeaderCell";
   return self;
 }
 
+- (void)dealloc {
+  [_treeController release];
+  [_datasource release];
+  [_menu release];
+  [super dealloc];
+}
+
 - (void)didLoadView {
   [_outlineView setDelegate:self];
   [_outlineView setMenu:[self _contextMenu]];

MacPass/MPPasswordCreatorViewController.m

@@ -54,6 +54,12 @@
   return self;
 }
 
+- (void)dealloc {
+  [_generatedPassword release];
+  [_password release];
+  [super dealloc];
+}
+
 - (void)didLoadView {
   [self.passwordLengthSlider setMinValue:MIN_PASSWORD_LENGTH];
   [self.passwordLengthSlider setMaxValue:MAX_PASSWORD_LENGTH];

MacPass/MPSettingsWindowController.m

@@ -45,6 +45,7 @@
   [_settingsController release];
   [_toolbar release];
   [_toolbarItems release];
+  [_defaultToolbarItems release];
   [super dealloc];
 }
 

MacPass/MPToolbarDelegate.m

@@ -48,9 +48,9 @@ NSString *const MPToolbarItemInspector = @"TOOLBAR_INSPECTOR";
 
 - (void)dealloc
 {
-  self.toolbarIdentifiers = nil;
+  [_toolbarItems release];
-  self.toolbarImages = nil;
+  [_toolbarIdentifiers release];
-  self.toolbarItems = nil;
+  [_toolbarImages release];
   [super dealloc];
 }
 
@@ -88,6 +88,7 @@ NSString *const MPToolbarItemInspector = @"TOOLBAR_INSPECTOR";
       [popupButton setFrame:newFrame];
       [popupButton setMenu:menu];
       [item setMenuFormRepresentation:menuRepresentation];
+      [menuRepresentation release];
       [item setView:popupButton];
       [popupButton release];
       [menu release];
@@ -113,6 +114,7 @@ NSString *const MPToolbarItemInspector = @"TOOLBAR_INSPECTOR";
                                                                   action:[self _actionForToolbarItemIdentifier:itemIdentifier]
                                                            keyEquivalent:@""];
       [item setMenuFormRepresentation:menuRepresentation];
+      [menuRepresentation release];
       [button release];
     }
     self.toolbarItems[itemIdentifier] = item;

MacPass/MacPass-Info.plist

@@ -48,7 +48,7 @@
 	<key>CFBundleSignature</key>
 	<string>????</string>
 	<key>CFBundleVersion</key>
-	<string>1167</string>
+	<string>1175</string>
 	<key>LSMinimumSystemVersion</key>
 	<string>${MACOSX_DEPLOYMENT_TARGET}</string>
 	<key>NSHumanReadableCopyright</key>