From 09b9b5fbb635a47fa276b80e274cc26825b639dd Mon Sep 17 00:00:00 2001 From: michael starke Date: Thu, 19 Oct 2017 17:06:43 +0200 Subject: [PATCH] Extended localization comments --- MacPass/Base.lproj/Localizable.strings | 2 +- MacPass/MPAddEntryContextMenuDelegate.m | 10 +++++----- MacPass/en.lproj/Localizable.strings | 4 ++-- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/MacPass/Base.lproj/Localizable.strings b/MacPass/Base.lproj/Localizable.strings index 8ed6c7af..f5b5ed2b 100644 --- a/MacPass/Base.lproj/Localizable.strings +++ b/MacPass/Base.lproj/Localizable.strings @@ -1,4 +1,4 @@ -/* Formatted Times */ +/* Formatted Times */ "%ld_DAYS_AGO" = "%ld days ago"; "%ld_HOURS_AGO" = "about %ld hours ago"; "%ld_MINUTES_AGO" = "%ld minutes ago"; diff --git a/MacPass/MPAddEntryContextMenuDelegate.m b/MacPass/MPAddEntryContextMenuDelegate.m index 1d5cde84..5ebb5b7a 100644 --- a/MacPass/MPAddEntryContextMenuDelegate.m +++ b/MacPass/MPAddEntryContextMenuDelegate.m @@ -42,20 +42,20 @@ [menu removeAllItems]; } [menu removeAllItems]; - [menu addItemWithTitle:NSLocalizedString(@"EDIT_TEMPLATE_GROUP", "") action:[MPActionHelper actionOfType:MPActionEditTemplateGroup] keyEquivalent:@""]; + [menu addItemWithTitle:NSLocalizedString(@"EDIT_TEMPLATE_GROUP", "Menu item on the add entry context menu to edit template groups") action:[MPActionHelper actionOfType:MPActionEditTemplateGroup] keyEquivalent:@""]; [menu addItem:[NSMenuItem separatorItem]]; for(KPKEntry *entry in [document.templates childEntries]) { - NSString *templateMask = NSLocalizedString(@"NEW_ENTRY_WITH_TEMPLATE_%@", ""); + NSString *templateMask = NSLocalizedString(@"NEW_ENTRY_WITH_TEMPLATE_%@", "Submenu to add an entry via template"); NSMenuItem *templateItem = [[NSMenuItem allocWithZone:[NSMenu menuZone]] initWithTitle:[NSString stringWithFormat:templateMask, entry.title] action:@selector(createEntryFromTemplate:) keyEquivalent:@""]; - [templateItem setRepresentedObject:entry.uuid]; + templateItem.representedObject = entry.uuid; [menu addItem:templateItem]; } /* If there are no entries, add a note as disabled menu item */ - if([[menu itemArray] count] == 2) { - [menu addItemWithTitle:NSLocalizedString(@"NO_TEMPLATES", "") action:NULL keyEquivalent:@""]; + if(menu.itemArray.count == 2) { + [menu addItemWithTitle:NSLocalizedString(@"NO_TEMPLATES", "Menu item added to show that no templates are defined") action:NULL keyEquivalent:@""]; } } diff --git a/MacPass/en.lproj/Localizable.strings b/MacPass/en.lproj/Localizable.strings index 8ed6c7af..2983cf5f 100644 --- a/MacPass/en.lproj/Localizable.strings +++ b/MacPass/en.lproj/Localizable.strings @@ -1,4 +1,4 @@ -/* Formatted Times */ +/* Formatted Times */ "%ld_DAYS_AGO" = "%ld days ago"; "%ld_HOURS_AGO" = "about %ld hours ago"; "%ld_MINUTES_AGO" = "%ld minutes ago"; @@ -111,7 +111,7 @@ "COPY_USERNAME" = "Copy Username"; /* Dock Badge */ -"CLEARING_PASTEBOARD" = "…"; +"CLEARING_PASTEBOARD" = "Cleared"; /* Group Inspector */ /* Autotype Combobox */